Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-109276: libregrtest: WASM use filename for JSON#109340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
2948d9c to5e88a04CompareOn Emscripten and WASI platforms, or if --python command line optionis used, libregrtest now uses a filename for the JSON file.Emscripten and WASI buildbot workers run the main test process with adifferent Python (Linux) which spawns Emscripten/WASI processes usingthe command specified in --python command line option. Passing a filedescriptor from the parent process to the child process doesn't workin this case.* Add JsonFile and JsonFileType classes* Add RunTests.json_file_use_filename() method.* Add a test in test_regrtest on the --python command line option.* test_regrtest: add parallel=False parameter.* Split long RunWorkers._runtest() function into sub-functions.
5e88a04 tod19861fCompareFirst, I wrote PR#109326 to debug the issue and understand what's going on. Then I wrote this clean PR. Well. Sadly, this PR doesn't work as expected because I misunderstood how Emscripten/WASI buildbot workers run tests. On these buildbots, a first Linux x86-64 Python binary is used to run These test worker processes use the Emscripten/WASI runtime! So the parent and child processes don't run the same "platform"! Before, the result was serialized as JSON at the end of stdout. But it causes issues, so Ienhanced libregrtest to write the JSON into a separated file descriptor (change made 2 days ago). First probem: apparently, currently, it's not possible to pass a file descriptor from the Linux x86-64 Python to the Emscripten/WASI Python: it fails with So I wrote this PR to use anamed filename for the JSON file.Second problem: the Emscripten/WASI Python runtime doesn't have a full access to the filesystem, and paths are mapped differently. |
On Emscripten and WASI platforms, or if --python command line optionis used, libregrtest now uses a filename for the JSON file.Emscripten and WASI buildbot workers run the main test process with adifferent Python (Linux) which spawns Emscripten/WASI processes usingthe command specified in --python command line option. Passing a filedescriptor from the parent process to the child process doesn't workin this case.* Add JsonFile and JsonFileType classes* Add RunTests.json_file_use_filename() method.* Add a test in test_regrtest on the --python command line option.* test_regrtest: add parallel=False parameter.* Split long RunWorkers._runtest() function into sub-functions.
Uh oh!
There was an error while loading.Please reload this page.
On Emscripten and WASI platforms, or if --python command line option is used, libregrtest now uses a filename for the JSON file.
Emscripten and WASI buildbot workers run the main test process with a different Python (Linux) which spawns Emscripten/WASI processes using the command specified in --python command line option. Passing a file descriptor from the parent process to the child process doesn't work in this case.