Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-109276: libregrtest calls random.seed() before each test#109279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
libregrtest now calls random.seed() before running each test filewhen -r/--randomize command line option is used. Moreover, it's alsocalled in worker processes. It should help to make tests moredeterministic. Previously, it was only called once in the mainprocess before running all test files and it was not called in workerprocesses.* Convert some f-strings to regular strings in test_regrtest when f-string is not needed.* Remove unused all_methods variable from test_regrtest.* Add RunTests members are now mandatory.
vstinner added a commit to vstinner/cpython that referenced this pull requestSep 13, 2023
…thon#109279)libregrtest now calls random.seed() before running each test filewhen -r/--randomize command line option is used. Moreover, it's alsocalled in worker processes. It should help to make tests moredeterministic. Previously, it was only called once in the mainprocess before running all test files and it was not called in workerprocesses.* Convert some f-strings to regular strings in test_regrtest when f-string is not needed.* Remove unused all_methods variable from test_regrtest.* Add RunTests members are now mandatory.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
libregrtest now calls random.seed() before running each test file when -r/--randomize command line option is used. Moreover, it's also called in worker processes. It should help to make tests more deterministic. Previously, it was only called once in the main process before running all test files and it was not called in worker processes.