Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-109216: Fix possible memory leak inBUILD_MAP#109257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 1 commit intopython:mainfromsobolevn:issue-109216
Sep 12, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedSep 11, 2023•
edited by bedevere-bot
Loading

_PyDict_FromItems can only fail withMemoryError and several other errors which can be considered as disasters, not a regular control flow.

But, it should be now in sync withBUILD_CONST_KEY_MAP

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, that's a good catch. This bug looks quite old, it's in 3.11, and I think it existed even before this code was refactored in#31564.

@kumaraditya303
Copy link
Contributor

@sobolevn Can you manually backport this to older branches? Thanks

@sobolevn
Copy link
MemberAuthor

Sure, will do later today.

@sobolevnsobolevn added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsSep 12, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@sobolevn and@kumaraditya303, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 247ee1bf841524667f883ebba5e343101f609026 3.11

@miss-islington
Copy link
Contributor

Sorry,@sobolevn and@kumaraditya303, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 247ee1bf841524667f883ebba5e343101f609026 3.12

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@kumaraditya303kumaraditya303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@sobolevn@kumaraditya303@miss-islington@gvanrossum@bedevere-bot@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp