Sep 6, 2023 · Sep 5, 2023 · Sep 5, 2023 · Sep 5, 2023 · Sep 5, 2023
diff --git a/Python/optimizer.c b/Python/optimizer.c
    if (err <= 0) {
        assert(executor == NULL);
        if (err < 0) {
            _PyFrame_SetStackPointer(frame, stack_pointer);
            return NULL;
        }
        goto jump_to_destination;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -169,6 +169,7 @@ _PyOptimizer_BackEdge(_PyInterpreterFrame frame, _Py_CODEUNIT src, _Py_CODEUNI
		if (err <= 0) {
		assert(executor == NULL);
		if (err < 0) {
		_PyFrame_SetStackPointer(frame, stack_pointer);
Copy link Member gvanrossumSep 5, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Oh, interesting. It seems this is needed because when`JUMP_BACKWARD` calls`_PyOptimizer_BackEdge` it doesn't update the stack pointer in the frame, it just passes the stack pointer to the optimizer, which upon success passes it to the executor, which will eventually call`STORE_SP()` to update the stack pointer in the frame. And sure, this PR seems to fix the hole, but I wonder if it wouldn't be more robust to just save it before even calling`_PyOptimizer_BackEdge`.
		return NULL;
		}
		goto jump_to_destination;
Expand Down