Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-104584: Restoreframe->stacktop on optimizer error#108953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stack_pointer on optimizer errorframe->stacktop on optimizer error
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just ran into this by coincidence. Fine to merge, but I do have a quibble (more aimed at@markshannon perhaps :-).
| if (err <=0) { | ||
| assert(executor==NULL); | ||
| if (err<0) { | ||
| _PyFrame_SetStackPointer(frame,stack_pointer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, interesting. It seems this is needed because whenJUMP_BACKWARD calls_PyOptimizer_BackEdge it doesn't update the stack pointer in the frame, it just passes the stack pointer to the optimizer, which upon success passes it to the executor, which will eventually callSTORE_SP() to update the stack pointer in the frame. And sure, this PR seems to fix the hole, but I wonder if it wouldn't be more robust to just save it before even calling_PyOptimizer_BackEdge.
Uh oh!
There was an error while loading.Please reload this page.