NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-89392: Remove support of test_main() in libregrtest#108876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:regretest-no-test_main

Sep 5, 2023

Merged

gh-89392: Remove support of test_main() in libregrtest#108876

serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:regretest-no-test_main

Sep 5, 2023

Conversation

Copy link

Member

serhiy-storchaka commentedSep 4, 2023•
edited by bedevere-bot
Loading

Issue:Always use unittest for collecting tests in regrtests #89392

pythongh-89392: Remove support of test_main() in libregrtest

59b2995

serhiy-storchaka added tests

Tests in the Lib/test dir

needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Sep 4, 2023

serhiy-storchaka requested a review fromvstinner

September 4, 2023 12:22

bedevere-bot added the awaiting core review label

Sep 4, 2023

bedevere-bot mentioned this pull request

Sep 4, 2023

Always use unittest for collecting tests in regrtests#89392

Closed

vstinner approved these changes

Sep 4, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I would prefer a better error message if a test module has a test_main() function.

Lib/test/libregrtest/runtest.py Outdated

		else:
		deftest_func():
		returnrun_unittest(test_mod)
		assertnothasattr(test_mod,"test_main")

Copy link

Member

vstinnerSep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please replace the assert with a regular exception. Like:

ifhasattr(test_mod,"test_main"):raiseException("Module {result.test_name} defines test_main() which is no longer supported by regrtest")

Maybe add a comment linking tohttps://github.com/python/cpython/issues/89392.

bedevere-bot added awaiting merge and removed awaiting core review labels

Sep 4, 2023

serhiy-storchaka commented

Sep 5, 2023

View reviewed changes

Lib/test/libregrtest/runtest.py OutdatedShow resolvedHide resolved

Update Lib/test/libregrtest/runtest.py

8e2ef4e

serhiy-storchaka merged commit04a0830 intopython:main

Sep 5, 2023

Copy link

Contributor

miss-islington commentedSep 5, 2023

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot added awaiting core review and removed awaiting merge labels

Sep 5, 2023

serhiy-storchaka deleted the regretest-no-test_main branch

September 5, 2023 05:36

Copy link

bedevere-bot commentedSep 5, 2023

There's a new commit after the PR has been approved.

@vstinner: please review the changes made to this pull request.

bedevere-bot requested a review fromvstinner

September 5, 2023 05:36

Copy link

Contributor

miss-islington commentedSep 5, 2023

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 04a0830b00879efe057e3dfe75e9aa9c0caf1a26 3.12

miss-islington assignedserhiy-storchaka

Sep 5, 2023

Copy link

Contributor

miss-islington commentedSep 5, 2023

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 04a0830b00879efe057e3dfe75e9aa9c0caf1a26 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Sep 5, 2023

[3.12]pythongh-89392: Remove support of test_main() in libregrtest (p…

06901ab

…ythonGH-108876).(cherry picked from commit04a0830)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Copy link

bedevere-bot commentedSep 5, 2023

GH-108897 is a backport of this pull request to the3.12 branch.

bedevere-bot removed the needs backport to 3.12only security fixes label

Sep 5, 2023

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Sep 5, 2023

[3.11]pythongh-89392: Remove support of test_main() in libregrtest (p…

d215892

…ythonGH-108876).(cherry picked from commit04a0830)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Copy link

bedevere-bot commentedSep 5, 2023

GH-108898 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Sep 5, 2023

serhiy-storchaka added a commit that referenced this pull request

Sep 5, 2023

[3.11]gh-89392: Remove support of test_main() in libregrtest (GH-108876

492e1ff

) (GH-108898)(cherry picked from commit04a0830)

Yhg1s pushed a commit that referenced this pull request

Sep 5, 2023

[3.12]gh-89392: Remove support of test_main() in libregrtest (GH-108876

5121faa

) (#108897)[3.12]gh-89392: Remove support of test_main() in libregrtest (GH-108876).(cherry picked from commit04a0830)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

serhiy-storchaka mentioned this pull request

Sep 5, 2023

Add missed "f" in an f-string#108906

Merged

serhiy-storchaka removed their assignment

Sep 8, 2023