Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Documentation: XML Element - pi objects instead of comment objects#108848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
update regarding second commit : docstring andsource code say it's a process instruction |
Uh oh!
There was an error while loading.Please reload this page.
| @@ -661,7 +661,7 @@ Functions | |||
| given. Returns an element instance, representing a processing instruction. | |||
| Note that :class:`XMLParser` skips over processing instructions | |||
| in the input instead of creatingcomment objects for them. An | |||
| in the input instead of creatingpi objects for them. An | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it clear? Maybe use "processing instruction objects"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Thanks@christopheNan for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
PI objects instead of comment objects.(cherry picked from commitde6f97c)Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
GH-114854 is a backport of this pull request to the3.12 branch. |
PI objects instead of comment objects.(cherry picked from commitde6f97c)Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
GH-114855 is a backport of this pull request to the3.11 branch. |
PI objects instead of comment objects.
Pour information, la traduction m'a amené à créer cette [PR](python/cpython#108848) dans CPython.Reviewed-on:https://git.afpy.org/AFPy/python-docs-fr/pulls/187Reviewed-by: Julien Palard <julien@palard.fr>Co-authored-by: Christophe Nanteuil <christophe.nanteuil@gmail.com>Co-committed-by: Christophe Nanteuil <christophe.nanteuil@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
While translating the XML documentation in French, I noticed that this would better describe the mechanism of parsing.
📚 Documentation preview 📚:https://cpython-previews--108848.org.readthedocs.build/