Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix sphinx warnings inuuid.rst#108805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromsobolevn:issue-101100-uuid
Sep 2, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedSep 2, 2023•
edited by github-actionsbot
Loading

Warnings before:

/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:22: WARNING: py:attr reference target not found: is_safe/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:102: WARNING: py:attr reference target not found: time_low/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:104: WARNING: py:attr reference target not found: time_mid/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:106: WARNING: py:attr reference target not found: time_hi_version/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:108: WARNING: py:attr reference target not found: clock_seq_hi_variant/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:110: WARNING: py:attr reference target not found: clock_seq_low/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:112: WARNING: py:attr reference target not found: node/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:116: WARNING: py:attr reference target not found: clock_seq/Users/sobolev/Desktop/cpython/Doc/library/uuid.rst:235: WARNING: py:attr reference target not found: variant

Turns out all attributes that are defined in.fields are not documented intentionally (as far as I understand from the docs.

📚 Documentation preview 📚:https://cpython-previews--108805.org.readthedocs.build/

@sobolevn
Copy link
MemberAuthor

Looks great:
Снимок экрана 2023-09-02 в 12 22 02

AlexWaygood reacted with heart emoji

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! And easier to later edit alist-table than mess with the "ASCII art" one :)

AlexWaygood reacted with rocket emoji
@hugovkhugovk added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsSep 2, 2023
@hugovkhugovkenabled auto-merge (squash)September 2, 2023 09:30
@sobolevn
Copy link
MemberAuthor

mess
"ASCII art"

😢

@hugovkhugovk merged commit21da498 intopython:mainSep 2, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

There's a new commit after the PR has been approved.

@hugovk: please review the changes made to this pull request.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 2, 2023
*pythongh-101100: Fix sphinx warnings in `uuid.rst`* Use anchors(cherry picked from commit21da498)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-108807 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelSep 2, 2023
@bedevere-bot
Copy link

GH-108808 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelSep 2, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 2, 2023
*pythongh-101100: Fix sphinx warnings in `uuid.rst`* Use anchors(cherry picked from commit21da498)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
- The last 48 bits of the UUID.

* - .. attribute:: UUID.time
- The the 60-bit timestamp.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, I missed the "the the" typo here. I've fixed it in the backports, please could you fixmain? (I'm on a phone, otherwise I could do it myself.) Thanks!

@hugovk
Copy link
Member

mess
"ASCII art"

😢

I mean it can be time-consuming to adjust the layout when changing text that then requires changing the number of hyphens, equals signs, whitespace and so on.

@sobolevnsobolevn mentioned this pull requestSep 2, 2023
- Meaning

* - .. attribute:: UUID.time_low
- The next 32 bits of the UUID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's another mistake here:

Suggested change
- Thenext 32 bits of the UUID.
- Thefirst 32 bits of the UUID.

@sobolevn, could you fix it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For future reference: this is being addressed in#108810

hugovk reacted with thumbs up emoji
@bedevere-bot
Copy link

GH-108808 is a backport of this pull request to the3.11 branch.

AlexWaygood added a commit that referenced this pull requestSep 2, 2023
)(cherry picked from commit21da498)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-108807 is a backport of this pull request to the3.12 branch.

Yhg1s pushed a commit that referenced this pull requestSep 2, 2023
)*gh-101100: Fix sphinx warnings in `uuid.rst` (GH-108805)*gh-101100: Fix sphinx warnings in `uuid.rst`* Use anchors(cherry picked from commit21da498)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>* Fix typo* another typo---------Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@sobolevn@miss-islington@bedevere-bot@hugovk@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp