Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-108765: Remove old prototypes from pyport.h#108782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:prototypes
Sep 2, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedSep 1, 2023•
edited by bedevere-bot
Loading

Move prototypes of gethostname(), _getpty() and struct termios from pyport.h to the C code using them: posixmodule.c, socketmodule.c and termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".

Move prototypes of gethostname(), _getpty() and struct termios frompyport.h to the C code using them: posixmodule.c, socketmodule.c andtermios.c.Replace "#ifdef SOLARIS" with "#ifdef __sun".
@vstinner
Copy link
MemberAuthor

Buildbots are happy with this change:#108784

@vstinnervstinner merged commit1f3e797 intopython:mainSep 2, 2023
@vstinnervstinner deleted the prototypes branchSeptember 2, 2023 13:46
@vstinner
Copy link
MemberAuthor

@kulikjak: It would be nice if you can double check the Solaris change:

Replace "#ifdef SOLARIS" with "#ifdef __sun".

@kulikjak
Copy link
Contributor

Hi@vstinner, can you, please, remove this part completely? There is already and issue and PR for this that is forgotten a little:
#63760
#23208

As mentioned there,gethostname() is defined now and both Oracle Solaris and OpenSolaris forks remove it:
https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patch

As for the define guard,if defined(__sun) && defined(__SVR4) is the best way to detect Solaris. (Although I guess there isn't that many people running 30+ years old preSRV4 SunOS systems and building latest Python :))

@kulikjak
Copy link
Contributor

I just realized that it's merged already - I rebased that older PR to remove it.
#23208

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@kulikjak@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp