NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-108634: PyInterpreterState_New() no longer calls Py_FatalError()#108748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:init_pystatus

Sep 1, 2023

Merged

gh-108634: PyInterpreterState_New() no longer calls Py_FatalError()#108748

vstinner merged 1 commit intopython:mainfromvstinner:init_pystatus

Sep 1, 2023

Conversation

Copy link

Member

vstinner commentedSep 1, 2023•
edited by bedevere-bot
Loading

PyInterpreterState_New() now raises a RuntimeError, instead of calling Py_FatalError() on error. And pycore_create_interpreter() now returns a status exception on error, rather than calling Py_FatalError().

Add _PyInterpreterState_New() function.
Replace Py_FatalError() with PyStatus in init_interpreter() and _PyObject_InitState().
_PyErr_SetFromPyStatus() now raises RuntimeError, instead of ValueError. It can now call PyErr_NoMemory() if it detects _PyStatus_NO_MEMORY().
init_runtime() cannot be called with _initialized=1: add an assertion in the caller instead.

Issue:Py_TRACE_REFS is not compatible with Py_LIMITED_API #108634

bedevere-bot mentioned this pull request

Aug 31, 2023

Py_TRACE_REFS is not compatible with Py_LIMITED_API#108634

Closed

2 tasks

bedevere-bot added the awaiting core review label

Sep 1, 2023

pythongh-108634: Add _PyInterpreterState_New() function

04627a8

pycore_create_interpreter() now returns a status exception on error,rather than calling Py_FatalError().* PyInterpreterState_New() now calls Py_ExitStatusException() instead  of calling Py_FatalError() directly.* Replace Py_FatalError() with PyStatus in init_interpreter() and  _PyObject_InitState().* _PyErr_SetFromPyStatus() now raises RuntimeError, instead of  ValueError. It can now call PyErr_NoMemory() if it detects  _PyStatus_NO_MEMORY().* init_runtime() cannot be called with _initialized=1: add an  assertion in the caller instead.