NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-106320: Remove private _PyLong_IsCompact() function#108742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

vstinner wants to merge1 commit intopython:mainfromvstinner:remove_pylong_iscompat

Closed

gh-106320: Remove private _PyLong_IsCompact() function#108742

vstinner wants to merge1 commit intopython:mainfromvstinner:remove_pylong_iscompat

Conversation

Copy link

Member

vstinner commentedSep 1, 2023•
edited by github-actionsbot
Loading

Move the private _PyLong_IsCompact() and _PyLong_CompactValue() functions to the internal C API (pycore_long.h). Public PyUnstable_Long_IsCompact() and PyUnstable_Long_CompactValue() functions can be used instead.

Remove "const" qualifier from PyUnstable_Long_IsCompact() and PyUnstable_Long_CompactValue() parameter type.

Issue:C API: Remove private C API functions (move them to the internal C API) #106320

📚 Documentation preview 📚:https://cpython-previews--108742.org.readthedocs.build/

vstinner added the skip news label

Sep 1, 2023

bedevere-bot mentioned this pull request

Sep 1, 2023

C API: Remove private C API functions (move them to the internal C API)#106320

Closed

bedevere-bot added the awaiting core review label

Sep 1, 2023

Copy link

MemberAuthor

vstinner commentedSep 1, 2023

With this change, PyUnstable_Long_IsCompact() and PyUnstable_Long_CompactValue() become regular opaque function calls. They are no longer implemented as static inline functions. That's needed to be able remove the 2 associated static inline functions from the public C API.

Remove "const" qualifier from PyUnstable_Long_IsCompact() and PyUnstable_Long_CompactValue() parameter type.

When I tried to use theconst qualified in the public C API in the past, I had issues :-( I prefer to avoid it. For the internal C API with static inline functions, that's fine.

See:

pythongh-106320: Remove private _PyLong_IsCompact() function

c6be6f8

Move the private _PyLong_IsCompact() and _PyLong_CompactValue()functions to the internal C API (pycore_long.h). PublicPyUnstable_Long_IsCompact() and PyUnstable_Long_CompactValue()functions can be used instead.Remove "const" qualifier from PyUnstable_Long_IsCompact() andPyUnstable_Long_CompactValue() parameter type.

vstinner force-pushed theremove_pylong_iscompat branch from1969769 toc6be6f8Compare

September 1, 2023 07:15

vstinner added the needs backport to 3.12only security fixes label

Sep 1, 2023

Copy link

MemberAuthor

vstinner commentedSep 1, 2023

@gvanrossum @markshannon: Are the private _PyLong_IsCompact() and _PyLong_CompactValue() functions exposed by<Python.h> on purpose? Or are you are ok to move them to theinternal C API?

I don't know the impact on performance. I'm more in favor ofhiding implementation details.

If these functions are moved to the internal C API, are you ok to also make this change in Python 3.12?

Remove "const" qualifier from PyUnstable_Long_IsCompact() and PyUnstable_Long_CompactValue() parameter type.

I don't have a strong opinion on that, I'm also fine with keeping const if you prefer :-) It's just that in the past, I tried to useconst in the public C API and "I got issues".