Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106320: Remove private _PyErr_ChainExceptions()#108713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:remove_chain_exc
Aug 31, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedAug 31, 2023•
edited by bedevere-bot
Loading

Remove _PyErr_ChainExceptions(), _PyErr_ChainExceptions1() and _PyErr_SetFromPyStatus() functions from the public C API.

  • Move the private _PyErr_ChainExceptions() and _PyErr_ChainExceptions1() function to the internal C API (pycore_pyerrors.h).
  • Move the private _PyErr_SetFromPyStatus() to the internal C API (pycore_initconfig.h).
  • No longer export the _PyErr_ChainExceptions() function.
  • Move run_in_subinterp_with_config() from _testcapi to _testinternalcapi.

Remove _PyErr_ChainExceptions(), _PyErr_ChainExceptions1() and_PyErr_SetFromPyStatus() functions from the public C API.* Move the private _PyErr_ChainExceptions() and  _PyErr_ChainExceptions1() function to the internal C API  (pycore_pyerrors.h).* Move the private _PyErr_SetFromPyStatus() to the internal C API  (pycore_initconfig.h).* No longer export the _PyErr_ChainExceptions() function.* Move run_in_subinterp_with_config() from _testcapi to  _testinternalcapi.
@vstinner
Copy link
MemberAuthor

Oh, this change introduced a warning on Windows: fixed by PR#108720.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE RHEL7 LTO + PGO 3.x has failed when building commit79823c1.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/43/builds/4141) and take a look at the build logs.
  4. Check if the failure is related to this commit (79823c1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/43/builds/4141

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks
  • test_interpreter_shutdown - test.test_concurrent_futures.test_shutdown.ProcessPoolSpawnProcessPoolShutdownTest.test_interpreter_shutdown
  • test_rapid_restart - test.test_multiprocessing_spawn.test_manager.WithManagerTestManagerRestart.test_rapid_restart

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

438 tests OK.

10 slowest tests:

  • test_math: 2 min 29 sec
  • test_hashlib: 1 min 53 sec
  • test.test_concurrent_futures.test_wait: 1 min 17 sec
  • test.test_multiprocessing_spawn.test_processes: 1 min 11 sec
  • test_unparse: 57.9 sec
  • test_tokenize: 57.6 sec
  • test_socket: 54.2 sec
  • test_signal: 52.2 sec
  • test.test_multiprocessing_forkserver.test_processes: 48.6 sec
  • test_unicodedata: 46.8 sec

1 test failed:
test.test_concurrent_futures.test_shutdown

23 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_idle test_ioctl test_kqueue test_launcher test_perf_profiler
test_smtpnet test_sqlite3 test_ssl test_startfile test_tcl
test_tkinter test_ttk test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

3 re-run tests:
test.test_asyncio.test_subprocess
test.test_concurrent_futures.test_shutdown
test.test_multiprocessing_spawn.test_manager

Total duration: 5 min 22 sec

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/test/_test_multiprocessing.py", line3138, intest_rapid_restart    manager.start()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/managers.py", line569, instartself._address= reader.recv()^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/connection.py", line249, inrecv    buf=self._recv_bytes()^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/connection.py", line413, in_recv_bytes    buf=self._recv(4)^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/connection.py", line382, in_recvraiseEOFErrorEOFErrorTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/process.py", line314, in_bootstrapself.run()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/process.py", line108, inrunself._target(*self._args,**self._kwargs)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/managers.py", line594, in_run_server    server=cls._Server(registry, address, authkey, serializer)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/managers.py", line159, in__init__self.listener= Listener(address=address,backlog=16)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/connection.py", line447, in__init__self._listener= SocketListener(address, family, backlog)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/connection.py", line590, in__init__self._socket.bind(address)OSError:[Errno 98] Address already in useTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line788, intest_subprocess_consistent_callbacksself.loop.run_until_complete(main())  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/asyncio/base_events.py", line664, inrun_until_completereturn future.result()^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/test/test_asyncio/test_subprocess.py", line780, inmainself.assertEqual(events, [AssertionError:Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/test/test_concurrent_futures/test_shutdown.py", line49, intest_interpreter_shutdownself.assertFalse(err)AssertionError: b'Exception in thread Thread-1:\nTraceback (most recent call last):\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/threading.py", line 1059, in _bootstrap_inner\n    self.run()\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/concurrent/futures/process.py", line 339, in run\n    self.add_call_item_to_queue()\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/concurrent/futures/process.py", line 394, in add_call_item_to_queue\n    self.call_queue.put(_CallItem(work_id,\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/queues.py", line 94, in put\n    self._start_thread()\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/queues.py", line 177, in _start_thread\n    self._thread.start()\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/threading.py", line 978, in start\n    _start_new_thread(self._bootstrap, ())\nRuntimeError: can\'t create new thread at interpreter shutdown\nTraceback (most recent call last):\n  File "<string>", line 1, in <module>\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/spawn.py", line 122, in spawn_main\n    exitcode = _main(fd, parent_sentinel)\n               ^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/spawn.py", line 132, in _main\n    self = reduction.pickle.load(from_parent)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/multiprocessing/synchronize.py", line 115, in __setstate__\n    self._semlock = _multiprocessing.SemLock._rebuild(*state)\n                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nFileNotFoundError: [Errno 2] No such file or directory\n' is not false

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vstinner@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp