🤖 New build scheduled with the buildbot fleet by@JelleZijlstra for commit8e8b41f 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

In offline conversation,@markshannon and@gvanrossum suggested that we should just always do this cleanup (regardless of whether there is an outer handler or not), for consistency of what appears in the frame under traceback inspection. The cost is only in code size (no perf cost unless an exception is raised), but overall code size is still likely smaller than the non-inlined version with a separate code object, so that's not a big concern.

I will make that update.

I'll also look into the buildbot failures here and see if any of them are legit related to this PR.

The refleak buildbots are all failing due to a refleak intest_import that was introduced a few days ago in main:#108696

This buildbot has been failing with the same crash for a while now:

• s390x Fedora LTO + PGO PR

These Clang buildbots have all been seeing the sametest_gdb failure (seems like#104736):

• s390x Fedora Clang PR
• aarch64 Fedora Stable Clang PR
• PPC64LE Fedora Stable Clang PR

PPC64 Fedora PR has been seeing the same timeout intest_math for a while.

AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR has been failingtest_socket for a while.

aarch64 Fedora Stable LTO + PGO PR andaarch64 Fedora Stable LTO PR have both been failing intest_concurrent_futures.test_shutdown multiple times already.

That leaves only thetest_perf_profiler failure, seen only onAMD64 Arch Linux Asan Debug PR, and not seen recently on that builder otherwise. I am not able to reproduce this failure locally in a debug+asan build, even with runningmake buildbottest in the same way the worker does. I suspect this is a flaky failure; rebuilding to see if the issue reproduces.

Rebuild was successful, so I believe this PR is buildbot-clean, relative to main branch.

Thanks@carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

GH-108700 is a backport of this pull request to the3.12 branch.

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable LTO 3.x has failed when building commitd52c448.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/336/builds/3864) and take a look at the build logs.
4. Check if the failure is related to this commit (d52c448) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/336/builds/3864

Failed tests:

• test.test_concurrent_futures.test_shutdown

Failed subtests:

• test_interpreter_shutdown - test.test_concurrent_futures.test_shutdown.ProcessPoolSpawnProcessPoolShutdownTest.test_interpreter_shutdown

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

447 tests OK.

10 slowest tests:

• test_gdb: 2 min 59 sec
• test.test_concurrent_futures.test_wait: 1 min 11 sec
• test.test_multiprocessing_spawn.test_processes: 1 min 10 sec
• test_signal: 1 min 3 sec
• test_socket: 47.5 sec
• test.test_multiprocessing_forkserver.test_processes: 41.4 sec
• test_io: 38.0 sec
• test_math: 37.1 sec
• test_subprocess: 35.5 sec
• test.test_multiprocessing_spawn.test_misc: 33.3 sec

1 test failed:
test.test_concurrent_futures.test_shutdown

14 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_ioctl
test_kqueue test_launcher test_startfile test_tkinter test_ttk
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test.test_concurrent_futures.test_shutdown

Total duration: 3 min 24 sec

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_concurrent_futures/test_shutdown.py", line49, intest_interpreter_shutdownself.assertFalse(err)AssertionError: b'Exception in thread Thread-1:\nTraceback (most recent call last):\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1059, in _bootstrap_inner\n    self.run()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/concurrent/futures/process.py", line 339, in run\n    self.add_call_item_to_queue()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/concurrent/futures/process.py", line 394, in add_call_item_to_queue\n    self.call_queue.put(_CallItem(work_id,\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/multiprocessing/queues.py", line 94, in put\n    self._start_thread()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/multiprocessing/queues.py", line 177, in _start_thread\n    self._thread.start()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 978, in start\n    _start_new_thread(self._bootstrap, ())\nRuntimeError: can\'t create new thread at interpreter shutdown\nTraceback (most recent call last):\n  File "<string>", line 1, in <module>\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/multiprocessing/spawn.py", line 122, in spawn_main\n    exitcode = _main(fd, parent_sentinel)\n               ^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/multiprocessing/spawn.py", line 132, in _main\n    self = reduction.pickle.load(from_parent)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/multiprocessing/synchronize.py", line 115, in __setstate__\n    self._semlock = _multiprocessing.SemLock._rebuild(*state)\n                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nFileNotFoundError: [Errno 2] No such file or directory\n' is not false