Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-108590: Fix sqlite3.iterdump for invalid unicode in text columns.#108657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 7 commits intopython:mainfromCorvinM:gh-108590
Aug 30, 2023

Conversation

CorvinM
Copy link
Contributor

@CorvinMCorvinM commentedAug 29, 2023•
edited
Loading

Fixes an exception where sqlite3.iterdump would fail to decode if someone stuffed invalid unicode into a database column marked as TEXT (or alias of, like VARCHAR).
See#108590 for more info

@CorvinMCorvinM marked this pull request as ready for reviewAugust 29, 2023 22:49
CorvinMand others added3 commitsAugust 30, 2023 03:41
…k0pOl.rstCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this, Corvin; it is a nice solution to this corner case.

I'll make some final adjustments before landing.

CorvinM reacted with thumbs up emoji
@erlend-aaslanderlend-aaslandenabled auto-merge (squash)August 30, 2023 08:28
@erlend-aaslanderlend-aasland added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsAug 30, 2023
@erlend-aaslanderlend-aasland linked an issueAug 30, 2023 that may beclosed by this pull request
2 tasks
@erlend-aasland
Copy link
Contributor

@CorvinM, you may also be interested in looking at#108364

CorvinM reacted with thumbs up emoji

@CorvinM
Copy link
ContributorAuthor

Thank you for the speedy reviews and helpful feedback 😄 Let me know if you want me to pick up anything else with this (e.g., backports)

erlend-aasland reacted with heart emoji

@erlend-aaslanderlend-aasland merged commit400a1ce intopython:mainAug 30, 2023
@miss-islington

This comment was marked as outdated.

@miss-islington
Copy link
Contributor

Sorry,@CorvinM and@erlend-aasland, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 400a1cebc743515e40157ed7af86e48d654290ce 3.12

@miss-islington
Copy link
Contributor

Sorry,@CorvinM and@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 400a1cebc743515e40157ed7af86e48d654290ce 3.11

@erlend-aasland
Copy link
Contributor

@CorvinM, can you handle the backports? You can use the cherry-picker. Seethe devguide.

@CorvinM
Copy link
ContributorAuthor

@CorvinM, can you handle the backports? You can use the cherry-picker. Seethe devguide.

Sure

CorvinM added a commit to CorvinM/cpython that referenced this pull requestAug 30, 2023
…EXT columns (pythonGH-108657)Co-authored-by: Erlend E. Aasland <erlend@python.org>.(cherry picked from commit400a1ce)Co-authored-by: Corvin <corvin@corvin.dev>
@bedevere-bot
Copy link

GH-108673 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelAug 30, 2023
CorvinM added a commit to CorvinM/cpython that referenced this pull requestAug 30, 2023
…EXT columns (pythonGH-108657)Co-authored-by: Erlend E. Aasland <erlend@python.org>.(cherry picked from commit400a1ce)Co-authored-by: Corvin <corvin@corvin.dev>
@bedevere-bot
Copy link

GH-108674 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelAug 30, 2023
erlend-aasland pushed a commit that referenced this pull requestAug 30, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestAug 30, 2023
erlend-aasland added a commit that referenced this pull requestAug 30, 2023
carljm added a commit to carljm/cpython that referenced this pull requestAug 30, 2023
* main:pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)pythongh-108590: Revertpythongh-108657 (commit400a1ce) (python#108686)pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)  Document Python build requirements (python#108646)pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)  Fix typo in multiprocessing docs (python#108666)pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)pythongh-106320: Remove private _Py_ForgetReference() (python#108664)  Mention Ellipsis pickling in the docs (python#103660)  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestAug 30, 2023
erlend-aasland added a commit that referenced this pull requestAug 30, 2023
(cherry picked from commit2a3926f)Reverted per Serhiy's request.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dotysandotysandotysan left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

@erlend-aaslanderlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3.iterdump() incompatible with binary data
5 participants
@CorvinM@erlend-aasland@miss-islington@bedevere-bot@dotysan
[8]ページ先頭
©2009-2025 Movatter.jp