NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-108455: peg_generator: install two stubs packages before running mypy#108637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

AlexWaygood merged 2 commits intopython:mainfromAlexWaygood:peg-stubs-packages

Aug 29, 2023

Merged

gh-108455: peg_generator: install two stubs packages before running mypy#108637

AlexWaygood merged 2 commits intopython:mainfromAlexWaygood:peg-stubs-packages

Aug 29, 2023

Conversation

Copy link

Member

AlexWaygood commentedAug 29, 2023•
edited by bedevere-bot
Loading

This means we no longer have totype: ignore unresolvable imports fromsetuptools andpsutil.

I tested the PR locally usingpython -m test test_peg_generator -u cpu -v.

Issue:Runmypy onTools/peg_generator #108455

peg_generator: install two stubs packages before running mypy

2d8fbd5

AlexWaygood added the skip news label

Aug 29, 2023

AlexWaygood requested a review fromsobolevn

August 29, 2023 14:05

AlexWaygood requested review frompablogsal andlysnikolaou ascode owners

August 29, 2023 14:05

bedevere-bot mentioned this pull request

Aug 29, 2023

Runmypy onTools/peg_generator#108455

Closed

bedevere-bot added the awaiting core review label

Aug 29, 2023

add comment

543b337

pablogsal approved these changes

Aug 29, 2023

View reviewed changes

AlexWaygood merged commit77e8f23 intopython:main

Aug 29, 2023

AlexWaygood deleted the peg-stubs-packages branch

August 29, 2023 19:14

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 29, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Aug 30, 2023

Merge branch 'main' into icompexc

37377e6

* main:pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)pythongh-108590: Revertpythongh-108657 (commit400a1ce) (python#108686)pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)  Document Python build requirements (python#108646)pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)  Fix typo in multiprocessing docs (python#108666)pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)pythongh-106320: Remove private _Py_ForgetReference() (python#108664)  Mention Ellipsis pickling in the docs (python#103660)  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)