NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-106320: Remove private _PyOS_IsMainThread() function#108605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:pycore_signal

Aug 29, 2023

Merged

gh-106320: Remove private _PyOS_IsMainThread() function#108605

vstinner merged 1 commit intopython:mainfromvstinner:pycore_signal

Aug 29, 2023

Conversation

Copy link

Member

vstinner commentedAug 29, 2023•
edited by bedevere-bot
Loading

Move the following private API to the internal C API (pycore_signal.h):

_PyOS_IsMainThread()
_PyOS_SigintEvent()

No longer export these functions.

Issue:C API: Remove private C API functions (move them to the internal C API) #106320

vstinner added the skip news label

Aug 29, 2023

bedevere-bot mentioned this pull request

Aug 29, 2023

C API: Remove private C API functions (move them to the internal C API)#106320

Closed

bedevere-bot added the awaiting core review label

Aug 29, 2023

pythongh-106320: Remove private _PyOS_IsMainThread() function

f3eaba7

Move the following private API to the internal C API(pycore_signal.h): _PyOS_IsMainThread() and _PyOS_SigintEvent().

vstinner force-pushed thepycore_signal branch from063392b tof3eaba7Compare

August 29, 2023 02:38

vstinnerenabled auto-merge (squash)

August 29, 2023 03:02

vstinner merged commitfadc2dc intopython:main

Aug 29, 2023

bedevere-bot removed the awaiting core review label

Aug 29, 2023

vstinner deleted the pycore_signal branch

August 29, 2023 03:40

Copy link

Contributor

jbms commentedDec 5, 2024

This breaks tensorstore, specifically due to the usage of_PyOS_SigintEvent here:https://github.com/google/tensorstore/blob/798025f874c7579b2eb900932bf7c56d4f8ebd62/python/tensorstore/future.cc#L75

It is used in order to make a blocking wait within the main thread interruptible via Control+C on Windows. I don't know of any easy alternative. For now I will be using the workaround of copying the declaration to my own source file, but if the function is eventually removed entirely that won't work.