NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-106320: Remove private _PyLong_New() function#108604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:pycore_long

Aug 29, 2023

Merged

gh-106320: Remove private _PyLong_New() function#108604

vstinner merged 1 commit intopython:mainfromvstinner:pycore_long

Aug 29, 2023

Conversation

Copy link

Member

vstinner commentedAug 29, 2023•
edited by bedevere-bot
Loading

Move the following private API to the internal C API (pycore_long.h):

_PyLong_Copy()
_PyLong_FromDigits()
_PyLong_New()

No longer export most of these functions.

Issue:C API: Remove private C API functions (move them to the internal C API) #106320

pythongh-106320: Remove private _PyLong_New() function

001cf8c

Move the following private API to the internal C API (pycore_long.h):* _PyLong_Copy()* _PyLong_FromDigits()* _PyLong_New()No longer export most of these functions.

vstinner added the skip news label

Aug 29, 2023

bedevere-bot mentioned this pull request

Aug 29, 2023

C API: Remove private C API functions (move them to the internal C API)#106320

Closed

bedevere-bot added the awaiting core review label

Aug 29, 2023

vstinner merged commit921eb8e intopython:main

Aug 29, 2023

bedevere-bot removed the awaiting core review label

Aug 29, 2023

vstinner deleted the pycore_long branch

August 29, 2023 02:59

Copy link

Contributor

skirpichev commentedOct 23, 2023

@vstinner, we use_PyLong_New() in the gmpy2, e.g. in theGMPy_PyLong_From_MPZ() method. What's now the intended replacement for this private API?

skirpichev mentioned this pull request

Oct 23, 2023

gh-106320: Move private _PyHash API to the internal C API#107026

Merged

Copy link

Contributor

skirpichev commentedOct 25, 2023

Another user is the sage:

$ git grep _PyLong_Nsrc/sage/libs/gmp/pylong.pyx:from cpython.longintrepr cimport _PyLong_New, py_long, digit, PyLong_SHIFTsrc/sage/libs/gmp/pylong.pyx:    L = _PyLong_New(pylong_size)

Copy link

MemberAuthor

vstinner commentedOct 27, 2023

we use _PyLong_New() in the gmpy2, e.g. in theGMPy_PyLong_From_MPZ() method. What's now the intended replacement for this private API?

Would you mind to open a separated issue describing how you use _PyLong_New() and which API do you need? _PyLong_New() changed a log in Python 3.12: see also issue#111140.