Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106320: Remove private _Py_Identifier API#108593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:pycore_identifier
Aug 29, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedAug 28, 2023•
edited by bedevere-bot
Loading

Remove the private _Py_Identifier type and related private functions from the public C API:

  • _PyObject_GetAttrId()
  • _PyObject_LookupSpecialId()
  • _PyObject_SetAttrId()
  • _PyType_LookupId()
  • _Py_IDENTIFIER()
  • _Py_static_string()
  • _Py_static_string_init()

Move them to the internal C API: add a new pycore_identifier.h header file. No longer export these functions.

@vstinner
Copy link
MemberAuthor

Remove the private _Py_Identifier type and related private functionsfrom the public C API:* _PyObject_GetAttrId()* _PyObject_LookupSpecialId()* _PyObject_SetAttrId()* _PyType_LookupId()* _Py_IDENTIFIER()* _Py_static_string()* _Py_static_string_init()Move them to the internal C API: add a new pycore_identifier.h headerfile. No longer export these functions.
@osandov
Copy link

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

@vstinner
Copy link
MemberAuthor

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

I'm worried about these APIs :-( No consensus was found on a migration plan to move away from this private API. Maybe we should consider adding back the private API for now until a clear consensus is found.

AlexWaygood reacted with thumbs up emoji

@vstinner
Copy link
MemberAuthor

@osandov:

Is there a recommendation for what to use instead? I read the discussion linked, but it didn't seem like there was a conclusion on the replacement.

I created#111484

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@osandov@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp