Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Docs: Resolve Sphinx warnings in dis.rst#108476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:docs/dis.rst
Aug 25, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedAug 25, 2023•
edited
Loading

  • Link to the code objects reference
  • Suppress link to deliberately undocumented builtins.__build_class__
  • Suppress links for example methods

📚 Documentation preview 📚:https://cpython-previews--108476.org.readthedocs.build/

- Link to the code objects reference- Suppress link to deliberately undocumented builtins.__build_class__- Suppress links for example methods
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@erlend-aasland
Copy link
ContributorAuthor

Thanks for the review, Alex!

AlexWaygood reacted with heart emoji

@erlend-aaslanderlend-aasland merged commitcb11842 intopython:mainAug 25, 2023
@miss-islington

This comment was marked as outdated.

@erlend-aaslanderlend-aasland deleted the docs/dis.rst branchAugust 25, 2023 11:28
@miss-islington

This comment was marked as outdated.

@miss-islington

This comment was marked as outdated.

@erlend-aasland

This comment was marked as outdated.

@serhiy-storchaka
Copy link
Member

LGTM.

erlend-aasland reacted with thumbs up emoji

@erlend-aaslanderlend-aasland added needs backport to 3.11only security fixes needs backport to 3.12only security fixes and removed needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsAug 27, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker cb1184280b3fb369a07abb4153aa36829cf1df9b 3.11

@bedevere-bot
Copy link

GH-108546 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelAug 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 27, 2023
- Link to the code objects reference- Suppress link to deliberately undocumented builtins.__build_class__- Suppress links for example methods(cherry picked from commitcb11842)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aaslanderlend-aasland removed the needs backport to 3.11only security fixes labelAug 27, 2023
@erlend-aasland
Copy link
ContributorAuthor

dis.rst looks a lot more different in 3.11 than in 3.12; I'm not sure that backport is worth it.

AlexWaygood reacted with thumbs up emoji

Yhg1s pushed a commit that referenced this pull requestAug 27, 2023
Docs: Resolve Sphinx warnings in dis.rst (GH-108476)- Link to the code objects reference- Suppress link to deliberately undocumented builtins.__build_class__- Suppress links for example methods(cherry picked from commitcb11842)Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

@erlend-aaslanderlend-aasland

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@erlend-aasland@miss-islington@serhiy-storchaka@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp