Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-108390: Prevent non-local events being set withsys.monitoring.set_local_events()#108420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 8 commits intopython:mainfromfaster-cpython:local-events-fix
Sep 5, 2023

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedAug 24, 2023•
edited by corona10
Loading

PEP 669 refers to "local events" and implies strongly, if not explicitly stated, that only local events can be set locally.
But, the implementation allows non-local events, likeRAISE, to be set locally.

This PR fixes that, which allows the crash reported in#108390 to be fixed as well.

Although a relatively large PR, as it will need backporting, it is really just splitting_Py_Monitors into_Py_LocalMonitors and_Py_GlobalMonitors and fixing the resulting compiler errors and warnings.

@markshannonmarkshannon changed the titleGH-10839: Prevent non-local events being set withsys.monitoring.set_local_events()GH-108390: Prevent non-local events being set withsys.monitoring.set_local_events()Aug 24, 2023
@markshannonmarkshannon added the needs backport to 3.12only security fixes labelAug 24, 2023
@markshannon
Copy link
MemberAuthor

Also fixes#108470

@brandtbucherbrandtbucher self-requested a reviewAugust 31, 2023 16:20
markshannonand others added2 commitsSeptember 1, 2023 16:49
Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>
Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Thanks@markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@markshannon, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 5a2a04615171899885b977d77dc379bd78bac87f 3.12

markshannon added a commit to faster-cpython/cpython that referenced this pull requestSep 5, 2023
markshannon added a commit to faster-cpython/cpython that referenced this pull requestSep 5, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 RHEL8 LTO 3.x has failed when building commit5a2a046.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/338/builds/4976) and take a look at the build logs.
  4. Check if the failure is related to this commit (5a2a046) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/338/builds/4976

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"<frozen importlib._bootstrap>", line1354, in_find_and_load  File"<frozen importlib._bootstrap>", line1325, in_find_and_load_unlocked  File"<frozen importlib._bootstrap>", line929, in_load_unlocked  File"<frozen importlib._bootstrap_external>", line1000, inexec_module  File"<frozen importlib._bootstrap_external>", line1096, inget_code  File"<frozen importlib._bootstrap_external>", line1195, inget_dataTypeError:descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' objectTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line1059, in_bootstrap_innerself.run()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line996, inrunself._target(*self._args,**self._kwargs)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters.py", line483, intask    interp= interpreters.create()^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters.py", line25, increateid= _interpreters.create(isolated=isolated)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^RuntimeError:interpreter creation failedk

markshannon added a commit to faster-cpython/cpython that referenced this pull requestSep 5, 2023
@bedevere-bot
Copy link

GH-108899 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelSep 5, 2023
Yhg1s pushed a commit that referenced this pull requestSep 5, 2023
…ring.set_local_events()` (GH-108420) (#108899)*GH-108390: Prevent non-local events being set with `sys.monitoring.set_local_events()` (GH-108420)* Restore generated objects* Restore size of monitoring arrays in code object for 3.12 ABI compatibility.* Update ABI file
@markshannonmarkshannon deleted the local-events-fix branchSeptember 5, 2023 12:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments

@iritkatrieliritkatrieliritkatriel approved these changes

+1 more reviewer

@chgnrdvchgnrdvchgnrdv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@markshannonmarkshannon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markshannon@miss-islington@bedevere-bot@iritkatriel@brandtbucher@chgnrdv
[8]ページ先頭
©2009-2025 Movatter.jp