Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs#108281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedAug 22, 2023•
edited
Loading

Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

  • create_function(name, nargs, callable, ...)
  • create_aggregate(name, nargs, callable)

The affected parameters will become positional-only in Python 3.15.

📚 Documentation preview 📚:https://cpython-previews--108281.org.readthedocs.build/

Deprecate passing name, number of arguments, and the callable as keywordarguments, for the following sqlite3.Connection APIs:- create_function(name, nargs, callable, ...)- create_aggregate(name, nargs, callable)Deprecate passing the callback as a keyword argument, for the followingsqlite3.Connection APIs:- set_authorizer(callback)- set_progress_handler(callback, n)- set_trace_callback(callback)The affected parameters will become positional-only in Python 3.15.
@erlend-aaslanderlend-aasland changed the titlegh-108278: Clean up some sqlite3 connection APIsgh-108278: Clean up sqlite3.Connection APIsAug 22, 2023
@erlend-aaslanderlend-aasland marked this pull request as ready for reviewAugust 22, 2023 20:05
@erlend-aaslanderlend-aasland changed the titlegh-108278: Clean up sqlite3.Connection APIsgh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIsAug 23, 2023
@erlend-aasland
Copy link
ContributorAuthor

I updated the PR to only affect UDF creation APIs.

@erlend-aasland
Copy link
ContributorAuthor

I'd like to land this; are you ok with the change,@serhiy-storchaka?

@erlend-aasland
Copy link
ContributorAuthor

I'm landing this. It is formain only, so we have until 3.13 feature freeze (~May 2024) to adjust things or even revert.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?

@erlend-aasland
Copy link
ContributorAuthor

LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?

I posted atopic on Discourse. Brett and Berker left a "heart" reaction; I did not get any discouragements. Since Berker also is a code owner for the sqlite3 code, I count that as fairly strong support.

serhiy-storchaka reacted with thumbs up emoji

@serhiy-storchaka
Copy link
Member

Well, then go ahead!

erlend-aasland reacted with hooray emojierlend-aasland reacted with heart emoji

@bedevere-bot
Copy link

There's a new commit after the PR has been approved.

@serhiy-storchaka: please review the changes made to this pull request.

vstinner pushed a commit to vstinner/cpython that referenced this pull requestAug 28, 2023
…args for sqlite3 UDF creation APIs (python#108281)Deprecate passing name, number of arguments, and the callable as keywordarguments, for the following sqlite3.Connection APIs:- create_function(name, nargs, callable, ...)- create_aggregate(name, nargs, callable)The affected parameters will become positional-only in Python 3.15.
@erlend-aaslanderlend-aasland deleted the sqlite/cleanup-connection-apis branchAugust 28, 2023 19:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@erlend-aasland@serhiy-storchaka@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp