Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.11] Trim trailing whitespace and test on CI (GH-104275)#108215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 8 commits intopython:3.11fromhugovk:3.11-pre-commit
Aug 22, 2023

Conversation

hugovk
Copy link
Member

No description provided.

@hugovk
Copy link
MemberAuthor

I'll follow this with a combined backport of#105750 and#108212.

I left them out of this one to keep things separate and clearer.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A lot of this diff is removing invisible pagebreak characters. For most of these cases, we should delete the whole line rather than just stripping the "trailing whitespace" from the line:

@AlexWaygood
Copy link
Member

See#102531 for where we removed invisible pagebreak characters from themain branch. (@hugovk, is it worth seeing if that PR could just be cleanly backported to 3.11?)

@hugovk
Copy link
MemberAuthor

Good idea, and it backported cleanly 🎉#108266

AlexWaygood reacted with rocket emoji

@AlexWaygood

This comment was marked as outdated.

@hugovk
Copy link
MemberAuthor

RevertedTrim trailing whitespace, will update 3.11 into here, and then see what's left to fix.

AlexWaygood reacted with thumbs up emoji

@hugovk
Copy link
MemberAuthor

And autofixed via pre-commit, let's check these changes.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovk
Copy link
MemberAuthor

And applied the two suggestions which were still available.

AlexWaygood reacted with thumbs up emoji

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM now, thank you!

@hugovkhugovk merged commitd678ee7 intopython:3.11Aug 22, 2023
@hugovkhugovk deleted the 3.11-pre-commit branchAugust 22, 2023 09:57
@hugovk
Copy link
MemberAuthor

Thank you very much for the reviews!

AlexWaygood reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@AlexWaygood@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp