Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-95065, gh-107704: Argument Clinic: support multiple '/ [from ...]' and '* [from ...]' markers#108132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedAug 19, 2023•
edited
Loading

It does not even make the code much more complex. Simply the code which checks that the version is the same is replaced with the code which supports multiple versions.

$ git diff main... --stat Tools/clinic/clinic.py Tools/clinic/clinic.py | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------- 1 file changed, 55 insertions(+), 50 deletions(-)

@erlend-aasland
Copy link
Contributor

It does not even make the code much more complex. Simply the code which checks that the version is the same is replaced with the code which supports multiple versions.

Indeed, the refactors from your previous PR came in handy here.

@erlend-aasland
Copy link
Contributor

Thanks, this is nice;@AlexWaygood, are you fine with this feature?

Copy link
Member

@AlexWaygoodAlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks pretty good to me! I'm impressed how little extra code it takes. I have one readability style nit.

I think we should maybe also add one or two examples tohttps://docs.python.org/3.13/howto/clinic.html#how-to-deprecate-passing-parameters-positionally-or-by-keyword that have mutliple/ [from ...] and* [from ...] markers

@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)August 21, 2023 13:41
@serhiy-storchakaserhiy-storchaka merged commit60942cc intopython:mainAug 21, 2023
@serhiy-storchakaserhiy-storchaka deleted the clinic-deprecated-multi branchAugust 21, 2023 17:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@erlend-aasland@AlexWaygood@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp