Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.12] gh-101100: Only show GitHub check annotations on changed doc paragraphs (GH-108065)#108127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ragraphs (pythonGH-108065)* Only show GitHub check annotations on changed doc paragraphs* Improve check-warnings script arg parsing following Hugo's suggestions* Factor filtering warnings by modified diffs into helper function* Build docs on unmerged branch so warning lines match & avoid deep clone---------(cherry picked from commiteb953d6)Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
CAM-Gerlach approved these changesAug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, to avoid the warning spam, fix the line numbers and allow them to be checked locally on this branch as well.
hugovk approved these changesAug 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
(cherry picked from commiteb953d6)
Co-authored-by: C.A.M. GerlachCAM.Gerlach@Gerlach.CAM
Co-authored-by: Hugo van Kemenadehugovk@users.noreply.github.com
Co-authored-by: Adam Turner9087854+AA-Turner@users.noreply.github.com
📚 Documentation preview 📚:https://cpython-previews--108127.org.readthedocs.build/