NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

GH-92584: Redirect to Setuptools' guidance on extension modules#108030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

AA-Turner wants to merge6 commits intopython:main

base:main

Choose a base branch

fromAA-Turner:drop-distutils-doc/ext-modules

Open

GH-92584: Redirect to Setuptools' guidance on extension modules#108030

AA-Turner wants to merge6 commits intopython:mainfromAA-Turner:drop-distutils-doc/ext-modules

Conversation

Copy link

Member

AA-Turner commentedAug 16, 2023•
edited by github-actionsbot
Loading

I'm unsure if we should just dropextending/windows entirely, as it internally reccomends just to usesetuptools:

Module authors are encouraged to use the distutils approach for building extension modules, instead of the one described in this section.

Issue:PEP 632: Remove the distutils package (Python 3.12) #92584

📚 Documentation preview 📚:https://cpython-previews--108030.org.readthedocs.build/

Redirect to Setuptools' guidance on extension modules

57960df

AA-Turner added docs

Documentation in the Doc dir

skip news needs backport to 3.12only security fixes labels

Aug 16, 2023

AA-Turner requested review fromvstinner,zooba andzware

August 16, 2023 15:04

bedevere-bot mentioned this pull request

Aug 16, 2023

PEP 632: Remove the distutils package (Python 3.12)#92584

Closed

bedevere-bot added the awaiting review label

Aug 16, 2023

Remove "Building C and C++ Extensions on Windows"

cbf59eb

Copy link

Member

zooba commentedAug 16, 2023

I'm unsure if we should just dropextending/windows entirely

It's got important information in there that probably doesn'tofficially exist anywhere else, and for POSIX devs trying to make stuff work on Windows I'm sure it's invaluable (though it would be nice to have similar guides for Windows devs trying to make stuff work on *nix, but I'm not going to hold my breath). Expecting people to extract the same information fromsetuptools or another backend is asking too much.

That said, it's in desperate need of cleanup and modernisation anyway, so I won't miss it. A cross-platform primer on building extension modules by hand (i.e. withoutsetuptools), referencingsysconfig heavily I'd expect, would be a great replacement.

Copy link

MemberAuthor

AA-Turner commentedAug 16, 2023

A cross-platform primer on building extension modules by hand (i.e. withoutsetuptools), referencingsysconfig heavily I'd expect, would be a great replacement.

Should we open a new issue for this?

Copy link

Member

zooba commentedAug 16, 2023•
edited
Loading

Should we open a new issue for this?

It won't hurt, but I'm not sure it'll help convince anyone to actually do it. But I don't know of any better place to put the note - maybe as a comment in the docs as well (referencing the soon-to-be-created new issue)?