Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-92584: Remove Installing Python Modules (Distutils version)#108020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 5 commits intopython:mainfromAA-Turner:drop-install
Aug 16, 2023

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedAug 16, 2023•
edited by github-actionsbot
Loading

This removesinstall/index, per the notice in the header:

The entiredistutils package has been deprecated and will be removed in Python 3.12. This documentation is retained as a reference only, and will be removed with the package.

See#108018 to retain the install scheme content in thesysconfig docs.

A

📚 Documentation preview 📚:https://cpython-previews--108020.org.readthedocs.build/

@vstinner
Copy link
Member

The doc fails to build:

Doc/library/site.rst:188: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@AA-Turner
Copy link
MemberAuthor

@vstinner thanks, I've removed the references so the build succeeds,#108018 will restore them.

A

Defines the:data:`user base directory <site.USER_BASE>`, which is used to
compute the path of the:data:`user site-packages directory <site.USER_SITE>`
and:ref:`Distutils installation paths<inst-alt-install-user>` for
and Distutils installation paths for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it really useful to keep a reference to removed Distutils? setup.py is legacy, no?

Copy link
MemberAuthor

@AA-TurnerAA-TurnerAug 16, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#108040 removes the reference to Distutils & replaces setup.py with pip, I wanted to keep each PR distinct. When the first one is merged I'll resolve the conflicts.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Conflicts resolved.

# Conflicts:#Doc/using/cmdline.rst
@vstinner
Copy link
Member

A Docs job failed:

Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)

@AA-Turner
Copy link
MemberAuthor

A Docs job failed:

Oh, I messed up the merge. Pushed a fix.

@vstinnervstinnerenabled auto-merge (squash)August 16, 2023 21:03
@vstinnervstinner merged commitfbb7cbc intopython:mainAug 16, 2023
@miss-islington
Copy link
Contributor

Thanks@AA-Turner for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@AA-Turner and@vstinner, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker fbb7cbc0e92168077fd56de942901511e99ca60a 3.12

@bedevere-bot
Copy link

GH-108062 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelAug 16, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull requestAug 16, 2023
…rsion) (pythonGH-108020).(cherry picked from commitfbb7cbc)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull requestAug 17, 2023
…GH-108020) (#108062)* [3.12]GH-92584: Remove Installing Python Modules (Distutils version) (GH-108020).(cherry picked from commitfbb7cbc)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@zoobazoobaAwaiting requested review from zooba

Assignees

@vstinnervstinner

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner@vstinner@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp