@vstinner: with this PR, sqlite3 emits a ResourceWarning ifclose() was not called explicitly on asqlite3.Connection object before it is deleted. I did not (yet) add a resource warning for the case where close fails (future enhancement).

As you can see from the test changes, we've been pretty lax with resource handling in the sqlite3 test suite 😆

UPDATE: Tests updated ingh-108017

cc.@felixxm

cc.@simonw

Thanks for the review, Victor! I asked about#108015 (comment) on the core dev Discord. If it is an issue, we can fix it later.

I'll wait with merging until I've heard from@simonw and@felixxm, in case they've got opinions about this.

Note: I intend to add ResourceWarnings in casesqlite3_close*() fails as well, but I will do that in a follow-up PR. Currently, the sqlite3 moduleasserts thatsqlite3_close*() did not fail, which is not optimal.

I'll wait with merging until I've heard from@simonw and@felixxm, in case they've got opinions about this.

Thanks for pinging me. I'm going to check it out next week, after my holidays 🏖️

I'll wait with merging until I've heard from@simonw and@felixxm, in case they've got opinions about this.

Thanks for pinging me. I'm going to check it out next week, after my holidays 🏖️

This change doesn't break anything important in Django 👍 (at the first glance). I've started fixingResourceWarnings in our tests, check outdjango/django#17178.

This change doesn't break anything important in Django 👍 (at the first glance). I've started fixingResourceWarnings in our tests, check outdjango/django#17178.

Great, thanks for chiming in.

Thanks for the reviews!

Congrats :-) IMO it's a nice enhancement.