Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-107932: Fix dis module for bytecode that does not have an associated source line#107988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedAug 15, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
bedevere-bot commentedAug 15, 2023
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for working on this.
The changes look correct, but the use ofFalse as a special value forstarts_line is a bit hard to follow.
Lib/test/test_dis.py is an endless source of merge conflicts, so I'll try merge ASAP after you've made the changes.
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedAug 18, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
CorvinM commentedAug 18, 2023
@markshannon Thanks for the quick review! I have made the requested changes; please review again. I have also updated the docs to reflect the changes and resolved the merge conflict (for now). I've listed the changes in the docs as happening in 3.13 (is this the correct procedure for the project?) |
bedevere-bot commentedAug 18, 2023
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, looks good.
erlend-aasland commentedAug 25, 2023
|
Uh oh!
There was an error while loading.Please reload this page.
Fix dis module for bytecode that does not have an associated source line.
fixes#107932
This does change behavior of many of the dis.py public functions to display lines with no source line mapping as such.
At the very least it changes:
findlinestarts - now returns starts of bytecode blocks that dont have a source line with lineno=None
dis/disassemble/distb/disco - now separates and labels lineno=None bytecode blocks, previously it lumped them into the previous block (see#107932)
get_instructions & Instruction - Instruction objects now have starts_line=False to indicate that the instruction does not start a line.
dis.dis()reports line numbers where there are none. #107932