Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py#107971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 18 commits intopython:mainfromiritkatriel:deopt
Aug 16, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedAug 15, 2023•
edited by bedevere-bot
Loading

Fidget-Spinner reacted with rocket emoji
@Eclips4Eclips4 added the interpreter-core(Objects, Python, Grammar, and Parser dirs) labelAug 15, 2023
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly LGTM. I've left a couple comments where there might be something further to be done.

(I'm approving under the assumption the comments will be resolved first, one way or another.)

@iritkatriel
Copy link
MemberAuthor

Mostly LGTM. I've left a couple comments where there might be something further to be done.

Thanks. A couple of tests for tracing/instrumentation are failing, I'm still debugging that.

@brettcannonbrettcannon removed their request for reviewAugust 15, 2023 21:57
@iritkatrieliritkatriel marked this pull request as ready for reviewAugust 16, 2023 16:17
@iritkatrieliritkatriel requested a review froma team as acode ownerAugust 16, 2023 16:17
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The revolution! It's almost here!!

A few nits but no need to wait for a re-review.

@@ -1617,197 +1616,197 @@ def _prepare_test_cases():
Instruction = dis.Instruction

expected_opinfo_outer = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This test is just preposterous. Let's commit to doing this in a different way in a future PR.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@markshannon loves to hate this test too.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@iritkatriel@ericsnowcurrently@gvanrossum@bedevere-bot@Eclips4
[8]ページ先頭
©2009-2025 Movatter.jp