NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-103363: Add follow_symlinks argument to`pathlib.Path.owner()` and`group()`#107962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

barneygale merged 10 commits intopython:mainfromkamilturek:gh-103363

Dec 4, 2023

Merged

gh-103363: Add follow_symlinks argument to`pathlib.Path.owner()` and`group()`#107962

barneygale merged 10 commits intopython:mainfromkamilturek:gh-103363

Dec 4, 2023

Conversation

Copy link

Contributor

kamilturek commentedAug 15, 2023•
edited by AA-Turner
Loading

Issue:pathlib.Path.owner() and.group() should accept afollow_symlinks argument #103363

📚 Documentation preview 📚:https://cpython-previews--107962.org.readthedocs.build/

kamilturek added3 commits

August 14, 2023 21:03

Add follow_symlinks argument to pathlib.Path.owner() and pathlib.Path…

530f085

….group()

Update pathlib docs

5b1578c

Add news entry

86a982d

bedevere-bot mentioned this pull request

Aug 15, 2023

pathlib.Path.owner() and.group() should accept afollow_symlinks argument#103363

Closed

kamilturek added2 commits

August 15, 2023 08:44

Update What's New

77d4d0f

Use correct method in test

cebcbc0

kamilturek changed the title~~gh-103363: Add follow_symlink argument topathlib.Path.owner() andgroup()~~gh-103363: Add follow_symlinks argument topathlib.Path.owner() andgroup()

Aug 15, 2023

Add missing follow_symlinks in tests

7296076

kamilturek marked this pull request as ready for review

August 15, 2023 11:27

kamilturek requested a review frombarneygale as acode owner

August 15, 2023 11:27

bedevere-bot added the awaiting review label

Aug 15, 2023

barneygale added the topic-pathlib label

Aug 25, 2023

This comment was marked as resolved.

barneygale requested changes

Nov 26, 2023

View reviewed changes

Copy link

Contributor

barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry it took me ages to review. Overall looks really good, thank you. Could you merge in the latestmain? You'll find there's a new_PathBase class with its ownowner() andgroup() methods - please add thefollow_symlinks argument there too. Thanks again!

Lib/test/test_pathlib.py OutdatedShow resolvedHide resolved

bedevere-appbot added awaiting changes and removed awaiting review labels

Nov 26, 2023

Copy link

bedevere-appbot commentedNov 26, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.