Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-105481: reduce repetition in opcode metadata generation code#107942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Optional suggestion.
| with self.metadata_item( | ||
| f"int _PyOpcode_num_{direction}(int opcode, int oparg, bool jump)", "", "" | ||
| ): | ||
| self.out.emit(" switch(opcode) {") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You could use ‘with self.out.block()’ and indent() here instead of adding spaces to the statements.
Uh oh!
There was an error while loading.Please reload this page.
This will simplify adding more stuff to the metadata.