Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-107803: double linked list implementation for asyncio tasks#107804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
35 commits Select commitHold shift + click to select a range
cc66eeb linked list
kumaraditya303d5a3d87 add tail optmiization to linked list
kumaraditya303a0c5fcf wip
kumaraditya30377d012f wip
kumaraditya3035d9653d wip
kumaraditya3035a00198 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya3034cdc834 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya30335a00f1 more fixes
kumaraditya303fddb9d6 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya3031d32835 finally it works
kumaraditya303b46bcfe Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya303ee7ead2 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya303af0280a add tests
kumaraditya303999fff7 remove weakreflist
kumaraditya30387a2231 add some comments
kumaraditya3031812408 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya3033cb5673 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya3039552636 reduce code duplication in _asynciomodule.c
kumaraditya3035c5b559 address some review comments
kumaraditya30382cf69b add invariants about the state of the linked list
kumaraditya3038998f6a add better explanation
kumaraditya303d93c4e1 clinic regen
kumaraditya30335726d9 reorder branches for better branch prediction
kumaraditya3038dd0492 Update Modules/_asynciomodule.c
kumaraditya3038325302 Apply suggestions from code review
kumaraditya30380b65e0 fix capturing of eager tasks
kumaraditya303b67649e add comment to task finalization
kumaraditya3031252b2f Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya303457739a Merge branch 'main' into linked-list
kumaraditya3034670731 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya303e061081 fix tests and couple c implmentation to c task
kumaraditya303836d254 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya303efce4b3 fix test
kumaraditya303c7b604c Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya30356beb04 Merge branch 'main' of https://github.com/python/cpython into linked-…
kumaraditya303File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
wip
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit77d012fc7c5f363f8066db2b88076a4e6512db35
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1953,6 +1953,9 @@ register_task(asyncio_state *state, TaskObj *task) | ||
| { | ||
| assert(Task_Check(state, task)); | ||
kumaraditya303 marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| assert(task != &state->asyncio_tasks.tail); | ||
| if (task->prev != NULL) { | ||
| return; | ||
| } | ||
| assert(task->prev == NULL); | ||
kumaraditya303 marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| assert(task->next == NULL); | ||
| assert(state->asyncio_tasks.head != NULL); | ||
| @@ -1973,7 +1976,11 @@ unregister_task(asyncio_state *state, TaskObj *task) | ||
| { | ||
| assert(Task_Check(state, task)); | ||
| assert(task != &state->asyncio_tasks.tail); | ||
| if (task->prev == NULL) { | ||
| assert(task->next == NULL); | ||
| assert(state->asyncio_tasks.head != task); | ||
| return; | ||
| } | ||
| task->prev->next = task->next; | ||
| if (task->next == NULL) { | ||
| assert(state->asyncio_tasks.head == task); | ||
| @@ -1983,6 +1990,7 @@ unregister_task(asyncio_state *state, TaskObj *task) | ||
| } | ||
| task->next = NULL; | ||
| task->prev = NULL; | ||
| assert(state->asyncio_tasks.head != task); | ||
| } | ||
| static int | ||
| @@ -3583,21 +3591,32 @@ _asyncio_all_tasks_impl(PyObject *module, PyObject *loop) | ||
| if (tasks == NULL) { | ||
| return NULL; | ||
| } | ||
| if (loop == Py_None) { | ||
| loop = _asyncio_get_running_loop_impl(module); | ||
| if (loop == NULL) { | ||
| Py_DECREF(tasks); | ||
| return NULL; | ||
| } | ||
| } else { | ||
| Py_INCREF(loop); | ||
kumaraditya303 marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| } | ||
| asyncio_state *state = get_asyncio_state(module); | ||
| TaskObj *head = state->asyncio_tasks.head; | ||
| assert(head != NULL); | ||
| assert(head->next == NULL); | ||
| TaskObj *tail = &state->asyncio_tasks.tail; | ||
| while (head != tail) | ||
| { | ||
| if (head->task_loop == loop) { | ||
| if (PySet_Add(tasks, (PyObject *)head) < 0) { | ||
| Py_DECREF(tasks); | ||
| Py_DECREF(loop); | ||
| return NULL; | ||
| } | ||
| } | ||
| head = head->prev; | ||
kumaraditya303 marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| } | ||
| Py_DECREF(loop); | ||
| return tasks; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.