Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-107803: double linked list implementation for asyncio tasks#107804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
willingc merged 35 commits intopython:mainfromkumaraditya303:linked-list
Jun 22, 2024

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedAug 9, 2023•
edited by bedevere-bot
Loading

itamaro, jbower-fb, and kPsarakis reacted with hooray emojiitamaro and kPsarakis reacted with eyes emoji
@kumaraditya303kumaraditya303force-pushed thelinked-list branch 2 times, most recently from8d57b5a toaf0280aCompareAugust 9, 2023 10:28
@kumaraditya303kumaraditya303 added performancePerformance or resource usage topic-asyncio 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelsAug 9, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commitaf0280a 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelAug 9, 2023
@kumaraditya303kumaraditya303 marked this pull request as ready for reviewAugust 9, 2023 17:38
@kumaraditya303
Copy link
ContributorAuthor

I'll add Whats's New entry for this later together with other performance improvements so skipping news for now.

@gvanrossum
Copy link
Member

Is there someone else who could review this? I am currently scrambling.

@willingc
Copy link
Contributor

@kumaraditya303@itamaro I'm going to mark this "Awaiting changes" due to the merge conflict and the amount of time that has passed since it was opened. If after fixing the changes, you would like to have this reviewed again, please ping. Thanks!

itamaro reacted with thumbs up emoji

@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 21, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commitc7b604c 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 21, 2024
@kumaraditya303kumaraditya303 marked this pull request as ready for reviewJune 22, 2024 12:55
Copy link
Contributor

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes look good to me@kumaraditya303. Let's merge this and thanks for rebooting the PR.

@willingc
Copy link
Contributor

@kumaraditya303 I wasn't sure if we wanted to backport. Please do so if it makes sense. Thanks!

nineteendo reacted with thumbs up emoji

@kumaraditya303kumaraditya303 deleted the linked-list branchJune 23, 2024 04:24
mrahtz pushed a commit to mrahtz/cpython that referenced this pull requestJun 30, 2024
…ythonGH-107804)* linked list* add tail optmiization to linked list* wip* wip* wip* more fixes* finally it works* add tests* remove weakreflist* add some comments* reduce code duplication in _asynciomodule.c* address some review comments* add invariants about the state of the linked list* add better explanation* clinic regen* reorder branches for better branch prediction* Update Modules/_asynciomodule.c* Apply suggestions from code reviewCo-authored-by: Itamar Oren <itamarost@gmail.com>* fix capturing of eager tasks* add comment to task finalization* fix tests and couple c implmentation to c taskimproved linked-list logic and more comments* fix test---------Co-authored-by: Itamar Oren <itamarost@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
…ythonGH-107804)* linked list* add tail optmiization to linked list* wip* wip* wip* more fixes* finally it works* add tests* remove weakreflist* add some comments* reduce code duplication in _asynciomodule.c* address some review comments* add invariants about the state of the linked list* add better explanation* clinic regen* reorder branches for better branch prediction* Update Modules/_asynciomodule.c* Apply suggestions from code reviewCo-authored-by: Itamar Oren <itamarost@gmail.com>* fix capturing of eager tasks* add comment to task finalization* fix tests and couple c implmentation to c taskimproved linked-list logic and more comments* fix test---------Co-authored-by: Itamar Oren <itamarost@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…ythonGH-107804)* linked list* add tail optmiization to linked list* wip* wip* wip* more fixes* finally it works* add tests* remove weakreflist* add some comments* reduce code duplication in _asynciomodule.c* address some review comments* add invariants about the state of the linked list* add better explanation* clinic regen* reorder branches for better branch prediction* Update Modules/_asynciomodule.c* Apply suggestions from code reviewCo-authored-by: Itamar Oren <itamarost@gmail.com>* fix capturing of eager tasks* add comment to task finalization* fix tests and couple c implmentation to c taskimproved linked-list logic and more comments* fix test---------Co-authored-by: Itamar Oren <itamarost@gmail.com>
@kumaraditya303kumaraditya303 restored the linked-list branchApril 18, 2025 19:31
@kumaraditya303kumaraditya303 deleted the linked-list branchApril 18, 2025 19:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@itamaroitamaroitamaro approved these changes

@willingcwillingcwillingc approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

performancePerformance or resource usageskip newstopic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kumaraditya303@bedevere-bot@gvanrossum@itamaro@willingc
[8]ページ先頭
©2009-2025 Movatter.jp