Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

GH-103082: Document PEP-669: Low Impact Monitoring for CPython#107772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

markshannon merged 18 commits intopython:mainfromfaster-cpython:doc-669

Sep 5, 2023

Merged

GH-103082: Document PEP-669: Low Impact Monitoring for CPython#107772

markshannon merged 18 commits intopython:mainfromfaster-cpython:doc-669

Sep 5, 2023

Conversation

markshannon

Copy link

Member

markshannon commentedAug 8, 2023•
edited by bedevere-bot
Loading

Initial draft

📚 Documentation preview 📚:https://cpython-previews--107772.org.readthedocs.build/

Issue:Implement and document PEP 669. #103082

markshannon added3 commits

August 4, 2023 21:12

@markshannon

Add what's new for PEP 669

22e5d83

@markshannon

Document sys.monitoring. First draft.

6e5a435

@markshannon

Fix sphinx errors

e373cbe

@bedevere-bot

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

@markshannon

markshannon changed the title~~Document PEP-669: Low Impact Monitoring for CPython~~GH-103082: Document PEP-669: Low Impact Monitoring for CPython

@bedevere-bot

bedevere-bot mentioned this pull request

Implement and document PEP 669.#103082

Closed

4 tasks

jacobtylerwalls

jacobtylerwalls reviewed

View reviewed changes

Copy link

Contributor

jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Spotted a typo while here, cheers

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

AA-Turner

AA-Turner reviewed

View reviewed changes

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rstShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

markshannon added7 commits

August 28, 2023 01:02

@markshannon

Address review comments

c648e70

@markshannon

Merge branch 'main' into doc-669

ed94e2e

@markshannon

Use add more cross-references

c15022c

@markshannon

Fix note

5d54704

@markshannon

Fix lint

7a500bd

@markshannon

Fix lint

bb4100c

@markshannon

Another attempt to fix the syntax

181843e

@markshannon

markshannon marked this pull request as ready for review

August 31, 2023 10:40

AA-Turner

AA-Turner reviewed

View reviewed changes

Copy link

Member

AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggestions to remove double-spaces, and to remove an unneededsys.monitoring prefix from the function definitions -- they'll be added by Sphinx regardless as of the.. module:: directive at the top of the file, and removing them helps with line length/readability.

A

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

@AA-Turner

Copy link

Member

AA-Turner commentedSep 1, 2023

The patch mentiond forconf.py is:

diff --git a/Doc/conf.py b/Doc/conf.pyindex 16fd8bf2571..901b977fd71 100644--- a/Doc/conf.py+++ b/Doc/conf.py@@ -157,6 +157,8 @@     ('envvar', 'USER'),     ('envvar', 'USERNAME'),     ('envvar', 'USERPROFILE'),+    # sys.monitoring ignores+    ('py:class', 'range(6)'), ] # Temporary undocumented names.

AA-Turner

AA-Turner reviewed

View reviewed changes

Doc/library/sys.monitoring.rst OutdatedShow resolvedHide resolved

markshannonand others added8 commits

September 5, 2023 02:16

@markshannon

Remove double space

200e4a3

@markshannon

@AA-Turner

Update Doc/library/sys.monitoring.rst

fb16167

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

@markshannon

@AA-Turner

Update Doc/library/sys.monitoring.rst

bfb3b1d

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

@markshannon

@AA-Turner

Update Doc/library/sys.monitoring.rst

0833922

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

@markshannon

@AA-Turner

Update Doc/library/sys.monitoring.rst

6364315

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

@markshannon

@AA-Turner

Update Doc/library/sys.monitoring.rst

4894333

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

@markshannon

@AA-Turner

Apply suggestions from code review

a943679

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

@markshannon

Drop use of range(6) to avoid confusing sphinx

002e744

@markshannon

markshannon merged commit8b515f6 intopython:main

@Yhg1s

Copy link

Member

Yhg1s commentedSep 5, 2023

Is this getting backported to 3.12?

@markshannon

Copy link

MemberAuthor

markshannon commentedSep 5, 2023

Yes, it should be.

@markshannon

markshannon added the needs backport to 3.12only security fixes label

@miss-islington

Copy link

Contributor

miss-islington commentedSep 5, 2023

Thanks@markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

Copy link

bedevere-bot commentedSep 5, 2023

GH-108909 is a backport of this pull request to the3.12 branch.

@bedevere-bot

bedevere-bot removed the needs backport to 3.12only security fixes label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

@markshannon

@miss-islington

pythonGH-103082: Document PEP-669: Low Impact Monitoring for CPython (p…

75d5382

…ythonGH-107772)(cherry picked from commit8b515f6)Co-authored-by: Mark Shannon <mark@hotpy.org>

@markshannon

markshannon deleted the doc-669 branch

September 5, 2023 12:52

Yhg1s pushed a commit that referenced this pull request

@miss-islington

@markshannon

[3.12]GH-103082: DocumentPEP-669: Low Impact Monitoring for CPython (…

578b3ea

…GH-107772) (#108909)GH-103082: DocumentPEP-669: Low Impact Monitoring for CPython (GH-107772)(cherry picked from commit8b515f6)Co-authored-by: Mark Shannon <mark@hotpy.org>

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Documentation in the Doc dir

6 participants

@markshannon

@AA-Turner

@Yhg1s

@miss-islington

@bedevere-bot

@jacobtylerwalls

[8]ページ先頭

©2009-2025 Movatter.jp