Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-56166: Deprecate passing counts and maxsplit via position in re#107767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
hauntsaninja wants to merge4 commits intopython:mainfromhauntsaninja:gh-56166

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninjahauntsaninja commentedAug 8, 2023•
edited by bedevere-bot
Loading

Zac-HD reacted with heart emoji
@hauntsaninja
Copy link
ContributorAuthor

This is a very common mistake, see#99918 (comment)

@hauntsaninjahauntsaninja changed the titlegh-56166: Deprecate passing counts and flags via position in regh-56166: Deprecate passing counts and maxsplit via position in reAug 8, 2023
@serhiy-storchaka
Copy link
Member

Thank you for your PR@hauntsaninja, but there is a different solution to a problem with signature. Also, these parameters are not keyword-only yet, so they should not be documented so. Instead the deprecation of passing the corresponding arguments positionally should be documented. I created a different PR#107778.

@hauntsaninjahauntsaninja deleted the gh-56166 branchAugust 8, 2023 17:35
@terryjreedy
Copy link
Member

terryjreedy commentedAug 9, 2023•
edited
Loading

Since the other patch passed all checks, I am assuming that inspect.signature will continue to display '0' rather than'_zero_sentinal', so that the IDLE tests should continue as is.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy is a code owner

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hauntsaninja@serhiy-storchaka@terryjreedy@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp