Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-106368: Improve coverage reports for argument clinic#107693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
erlend-aasland approved these changesAug 6, 2023
Contributor
erlend-aasland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
...rather thanpassfor empty bodies in abstract methods that are never meant to be executed. Exclude lines consisting solely of...in our.coveragercfile.raise AssertionErrorinstead ofraise RuntimeErrorfor an exception that's never meant to be executed -- it would indicate a bug inTools/clinic/itself, rather than an incorrect usage of argument clinic, if that line was ever executed. Excluderaise AssertionError(lines in our.coveragercfile.Tools/clinic/cpp.pywas being excluded from coverage reports because it was all inside anif __name__ == "__main__"block, andif __name__ == "__main__"blocks are excluded in our.coveragercfile. That was making our coverage forcpp.pylook better than it actually was. Move that block inside a_main()function so that it's correctly reported as being uncovered in coverage reports.