NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

gh-107625: configparser: Raise ParsingError if a key contains empty value#107651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

encukou merged 23 commits intopython:mainfromAgent-Hellboy:fix-issue-107625

Mar 6, 2024

Merged

gh-107625: configparser: Raise ParsingError if a key contains empty value#107651

encukou merged 23 commits intopython:mainfromAgent-Hellboy:fix-issue-107625

Mar 6, 2024

Conversation

Copy link

Contributor

Agent-Hellboy commentedAug 5, 2023•
edited
Loading

raise ParsingError instead of AttributeError if a key contains an empty value in a non-recommended scenario where extra space and a blank line is present within the section

Issue:ConfigParser AttributeError: 'NoneType' object has no attribute 'append' #107625

📚 Documentation preview 📚:https://cpython-previews--107651.org.readthedocs.build/

pythongh-107625: Raise ParsingError if a key contains empty value

ec49bca

- raise ParsingError instaed of AttributeError if a key  contains empty value in a non recommended scenario where  extra space and blankline is present within the section

bedevere-bot mentioned this pull request

Aug 5, 2023

ConfigParser AttributeError: 'NoneType' object has no attribute 'append'#107625

Closed

2 tasks

bedevere-bot added the awaiting review label

Aug 5, 2023

AlexWaygood changed the title~~gh-107625: Raise ParsingError if a key contains empty value~~gh-107625: configparser: Raise ParsingError if a key contains empty value

Aug 5, 2023

Agent-Hellboyand others added4 commits

August 5, 2023 13:58

Fix doc

1bcab3f

Fix doc

35fe7f1

📜🤖 Added by blurb_it.

0660a7e

Fix test

317681c

ericvsmith reviewed

Aug 5, 2023

View reviewed changes

Doc/library/configparser.rstShow resolvedHide resolved

Doc/library/configparser.rst OutdatedShow resolvedHide resolved

Fix doc

ff8f339

Agent-Hellboy commented

Aug 5, 2023

View reviewed changes

Doc/library/configparser.rstShow resolvedHide resolved

Agent-Hellboy added3 commits

August 5, 2023 19:29

Fix doc

778841d

Fix Doc

ed50361

Fix whitespace issues

dc1faeb

merwok reviewed

Aug 5, 2023

View reviewed changes

Doc/library/configparser.rst OutdatedShow resolvedHide resolved

merwok reviewed

Aug 5, 2023

View reviewed changes

Doc/library/configparser.rst OutdatedShow resolvedHide resolved

merwok reviewed

Aug 5, 2023

View reviewed changes

Lib/configparser.py OutdatedShow resolvedHide resolved

merwok reviewed

Aug 5, 2023

View reviewed changes

Lib/test/test_configparser.py OutdatedShow resolvedHide resolved

merwok reviewed

Aug 5, 2023

View reviewed changes

Lib/test/test_configparser.pyShow resolvedHide resolved

merwok reviewed

Aug 5, 2023

View reviewed changes

Lib/test/test_configparser.py OutdatedShow resolvedHide resolved

merwok reviewed

Aug 5, 2023

View reviewed changes

Misc/NEWS.d/next/Library/2023-08-05-08-41-58.gh-issue-107625.cVSHCT.rst OutdatedShow resolvedHide resolved

Agent-Hellboyand others added6 commits

August 5, 2023 23:20

Update Lib/configparser.py

1234b75

Co-authored-by: Éric <merwok@netwok.org>

Update Lib/test/test_configparser.py

726264d

Co-authored-by: Éric <merwok@netwok.org>

Update Lib/test/test_configparser.py

7ae72b6

Co-authored-by: Éric <merwok@netwok.org>

Resolve comments

da065f8

Fix doc

ee11915

Add versionchnaged section inside documentation

0b87a9f

merwok reviewed

Aug 5, 2023

View reviewed changes

Misc/NEWS.d/next/Library/2023-08-05-08-41-58.gh-issue-107625.cVSHCT.rst OutdatedShow resolvedHide resolved

Agent-Hellboyand others added2 commits

August 6, 2023 00:21

Update Misc/NEWS.d/next/Library/2023-08-05-08-41-58.gh-issue-107625.c…

8c4907f

…VSHCT.rstCo-authored-by: Éric <merwok@netwok.org>

Fix doc

2b06e68

bedevere-bot added awaiting changes and removed awaiting review labels

Aug 10, 2023

Copy link

bedevere-bot commentedAug 10, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Raise MultilineContinuationError instead of ParsingError

ca4839d

Copy link

ContributorAuthor

Agent-Hellboy commentedAug 11, 2023

I have made the requested changes; please review again.

bedevere-bot added awaiting change review and removed awaiting changes labels

Aug 11, 2023

Copy link

bedevere-bot commentedAug 11, 2023

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

bedevere-bot requested a review fromambv

August 11, 2023 04:14

Copy link

Contributor

ambv commentedAug 11, 2023

Closing and re-opening to retrigger CLA checks. Sorry for the noise.

ambv closed this

Aug 11, 2023

ambv reopened this

Aug 11, 2023

Copy link

ContributorAuthor

Agent-Hellboy commentedOct 9, 2023

Hi@ambv, I thought you closed the PR, but it's still open, I have resolved your comments, please look again.

encukou added2 commits

March 4, 2024 14:56

Merge in the main branch

4383e06

Simplify the docs & error messages

2d367f1

Agent-Hellboy requested a review fromjaraco as acode owner

March 4, 2024 14:49

Copy link

Member

encukou commentedMar 4, 2024

I've mergedmain to fix a conflict, and reworded the docs & error to be more succinct. I hope you don't mind me pushing directly to the PR -- I wanted to test my suggestions locally so I already had them as commits.
Does this wording look OK to you?

jaraco reviewed

Mar 4, 2024

View reviewed changes

Lib/configparser.py OutdatedShow resolvedHide resolved

jaraco approved these changes

Mar 4, 2024

View reviewed changes

Copy link

Member

jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

bedevere-appbot added awaiting merge and removed awaiting change review labels

Mar 4, 2024

Update Lib/configparser.py

9dc65ed

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Copy link

ContributorAuthor

Agent-Hellboy commentedMar 5, 2024

Does this wording look OK to you?

yeah, it's better than the earlier error. Thanks

Test withis None rather thannot

0303728

encukou dismissedambv’sstale review

March 6, 2024 13:40

The issues were resolved

encukouenabled auto-merge (squash)

March 6, 2024 13:41

encukou merged commite800265 intopython:main

Mar 6, 2024

bedevere-appbot removed the awaiting merge label

Mar 6, 2024

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 25, 2024

pythongh-107625: configparser: Raise error if a missing value is cont…

e53e133

…inued (pythonGH-107651)Co-authored-by: Éric <merwok@netwok.org>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request

Apr 17, 2024

pythongh-107625: configparser: Raise error if a missing value is cont…

ca0a8aa

…inued (pythonGH-107651)Co-authored-by: Éric <merwok@netwok.org>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>