NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

GH-106684: raise ResourceWarning when StreamWriter is not closed#107650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 4 commits intopython:mainfromkumaraditya303:leak

Aug 5, 2023

Merged

GH-106684: raise ResourceWarning when StreamWriter is not closed#107650

kumaraditya303 merged 4 commits intopython:mainfromkumaraditya303:leak

Aug 5, 2023

Conversation

Copy link

Contributor

kumaraditya303 commentedAug 5, 2023•
edited by bedevere-bot
Loading

Issue:asyncio: potential leak of TLS connections #106684

raise ResourceWarning when StreamWriter is not closed

5e86cdf

bedevere-bot mentioned this pull request

Aug 5, 2023

asyncio: potential leak of TLS connections#106684

Closed

fix lint

066d128

Copy link

ContributorAuthor

kumaraditya303 commentedAug 5, 2023

Memray flamegraphs of code on issue.

Before:

After:

add test

f11cef0

kumaraditya303 added type-bug

An unexpected behavior, bug, or error

topic-asyncio needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Aug 5, 2023

📜🤖 Added by blurb_it.

1e9f902

kumaraditya303 marked this pull request as ready for review

August 5, 2023 05:28

kumaraditya303 requested review from1st1,asvetlov,gvanrossum andwillingc ascode owners

August 5, 2023 05:28

bedevere-bot added the awaiting core review label

Aug 5, 2023

asvetlov approved these changes

Aug 5, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 5, 2023

kumaraditya303 merged commit41178e4 intopython:main

Aug 5, 2023

Copy link

Contributor

miss-islington commentedAug 5, 2023

Thanks@kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Aug 5, 2023

kumaraditya303 deleted the leak branch

August 5, 2023 12:18

Copy link

bedevere-bot commentedAug 5, 2023

GH-107656 is a backport of this pull request to the3.12 branch.

bedevere-bot removed the needs backport to 3.12only security fixes label

Aug 5, 2023

Copy link

bedevere-bot commentedAug 5, 2023

GH-107657 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Aug 5, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 5, 2023

pythonGH-106684: raiseResourceWarningwhenasyncio.StreamWriter…

0004686

…is not closed (pythonGH-107650)(cherry picked from commit41178e4)Co-authored-by: Kumar Aditya <kumaraditya@python.org>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 5, 2023

pythonGH-106684: raiseResourceWarningwhenasyncio.StreamWriter…

385390a

…is not closed (pythonGH-107650)(cherry picked from commit41178e4)Co-authored-by: Kumar Aditya <kumaraditya@python.org>

evildmp pushed a commit to evildmp/cpython that referenced this pull request

Aug 5, 2023

pythonGH-106684: raiseResourceWarningwhenasyncio.StreamWriter…

d999392

…is not closed (python#107650)

Copy link

bedevere-bot commentedAug 10, 2023

GH-107656 is a backport of this pull request to the3.12 branch.

Yhg1s pushed a commit that referenced this pull request

Aug 10, 2023

[3.12]GH-106684: Closeasyncio.StreamWriterwhen `asyncio.StreamWr…

7853c76

…iter` is not closed by application (GH-107650) (#107656)GH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (GH-107650)(cherry picked from commit41178e4)Co-authored-by: Kumar Aditya <kumaraditya@python.org>Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

miss-islington mentioned this pull request

Aug 10, 2023

[3.11] [3.12] GH-106684: Closeasyncio.StreamWriter whenasyncio.StreamWriter is not closed by application (GH-107650) (GH-107656)#107836

Merged

miss-islington added a commit to miss-islington/cpython that referenced this pull request

Aug 10, 2023

[3.12]pythonGH-106684: Closeasyncio.StreamWriterwhen `asyncio.St…

91ce3ac

…reamWriter` is not closed by application (pythonGH-107650) (pythonGH-107656)pythonGH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (pythonGH-107650)(cherry picked from commit41178e4)(cherry picked from commit7853c76)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

kumaraditya303 added a commit that referenced this pull request

Aug 10, 2023

[3.11] [3.12]GH-106684: Closeasyncio.StreamWriterwhen `asyncio.S…

fb08b79

…treamWriter` is not closed by application (GH-107650) (GH-107656) (#107836)[3.12]GH-106684:  Close `asyncio.StreamWriter` when `asyncio.StreamWriter` is not closed by application (GH-107650) (GH-107656)GH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (GH-107650)(cherry picked from commit41178e4)(cherry picked from commit7853c76)Co-authored-by: Kumar Aditya <kumaraditya@python.org>