NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-106368: Increase test coverage for Argument Clinic#107514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 6 commits intopython:mainfromerlend-aasland:clinic/coverage

Aug 2, 2023

Merged

gh-106368: Increase test coverage for Argument Clinic#107514

erlend-aasland merged 6 commits intopython:mainfromerlend-aasland:clinic/coverage

Aug 2, 2023

Conversation

Copy link

Contributor

erlend-aasland commentedJul 31, 2023•
edited by bedevere-bot
Loading

Issue:Increase Argument Clinic test coverage #106368

pythongh-106368: Increase test coverage for Argument Clinic

8f1a9af

erlend-aasland requested a review fromAlexWaygood as acode owner

July 31, 2023 21:11

erlend-aasland added skip news needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Jul 31, 2023

erlend-aasland requested a review fromsobolevn

July 31, 2023 21:11

bedevere-bot added the awaiting core review label

Jul 31, 2023

bedevere-bot mentioned this pull request

Jul 31, 2023

Increase Argument Clinic test coverage#106368

Closed

Copy link

ContributorAuthor

erlend-aasland commentedJul 31, 2023

With this, we're pretty good covered (above 90%). AFAICS, converters, return converters, and most parser code has been tested. Most of what's missing is various error paths.

I suggest we close the linked issue after landing this.

AlexWaygood reviewed

Jul 31, 2023

View reviewed changes

Lib/test/test_clinic.py OutdatedShow resolvedHide resolved

sobolevn reviewed

Jul 31, 2023

View reviewed changes

Copy link

Member

sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 👍

Lib/test/clinic.test.c OutdatedShow resolvedHide resolved

Lib/test/test_clinic.py OutdatedShow resolvedHide resolved

AlexWaygood mentioned this pull request

Aug 2, 2023

gh-104683: Rework Argument Clinic error handling#107551

Merged

erlend-aasland added3 commits

August 2, 2023 13:12

Pull in main

2acaed4

Fix clinic.test.c

7c06c31

Parametrise version directive tests

00a9557

erlend-aasland requested review fromAlexWaygood andsobolevn

August 2, 2023 12:12

This comment was marked as outdated.

erlend-aasland added2 commits

August 2, 2023 14:44

Pull in main

15140d0

Partially revert parametrised tests

0618a20

AlexWaygood approved these changes

Aug 2, 2023

View reviewed changes

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)

erlend-aasland linked an issue

Aug 2, 2023

that may beclosed by this pull request

Increase Argument Clinic test coverage#106368

Closed

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 2, 2023

Copy link

ContributorAuthor

erlend-aasland commentedAug 2, 2023

The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)

Thanks for the review; Nikita gave a thumbs up for the functional tests earlier, so I'll enable auto-merge 🚀

erlend-aaslandenabled auto-merge (squash)

August 2, 2023 12:50

erlend-aasland merged commitb9c9a36 intopython:main

Aug 2, 2023

Copy link

Contributor

miss-islington commentedAug 2, 2023

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Aug 2, 2023

Copy link

Contributor

miss-islington commentedAug 2, 2023

Sorry,@erlend-aasland, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker b9c9a36c2f2edc11b9c27eb7c5810919d9da9767 3.12

miss-islington assignederlend-aasland

Aug 2, 2023

Copy link

Contributor

miss-islington commentedAug 2, 2023

Sorry,@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker b9c9a36c2f2edc11b9c27eb7c5810919d9da9767 3.11

erlend-aasland deleted the clinic/coverage branch

August 2, 2023 13:36

Copy link

Member

picnixz commentedSep 14, 2024

3.11 and 3.12 never got their backports but I'm removing the labels (I'm going through PRs to see if we did not forgot a backport) (not sure if you want to backport this on 3.12)