Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-107091: Fix some uses of :const: role#107379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJul 28, 2023•
edited by github-actionsbot
Loading

It is for references, not for literals.
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. The old usage ofconst looks suspicious and wrong. Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!

@miss-islington
Copy link
Contributor

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the docs-const-role branchJuly 28, 2023 10:26
@bedevere-bot
Copy link

GH-107384 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 28, 2023
It is for references, not for literals.(cherry picked from commit0aa58fa)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 28, 2023
@bedevere-bot
Copy link

GH-107385 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 28, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 28, 2023
It is for references, not for literals.(cherry picked from commit0aa58fa)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJul 28, 2023
It is for references, not for literals.(cherry picked from commit0aa58fa)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Copy link
MemberAuthor

Congrats for fixing one more file in Doc/tools/.nitignore, for me a single fixed file is already a great success!

Hold my beer.#107386

AlexWaygood reacted with laugh emojiAlexWaygood reacted with heart emoji

serhiy-storchaka added a commit that referenced this pull requestJul 28, 2023
It is for references, not for literals.(cherry picked from commit0aa58fa)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@serhiy-storchaka@miss-islington@bedevere-bot@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp