Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-106368: Argument clinic tests: improve failure message when tests inClinicExternalTests fail#107364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ClinicExternalTests failClinicExternalTests failUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
erlend-aasland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! (BTW, I love itertools!)
miss-islington commentedJul 27, 2023
Thanks@AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
bedevere-bot commentedJul 27, 2023
GH-107365 is a backport of this pull request to the3.12 branch. |
bedevere-bot commentedJul 27, 2023
GH-107366 is a backport of this pull request to the3.11 branch. |
…tests in `ClinicExternalTests` fail (pythonGH-107364)(cherry picked from commit76c26ea)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
…tests in `ClinicExternalTests` fail (pythonGH-107364)(cherry picked from commit76c26ea)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Currently, if I apply this diff to
Tools/clinic/clinic.py......then the argument clinic tests fail for me locally (good!), but the failure message is terrible (bad!):
This change makes the error messagemuch more helpful!
(@erlend-aasland do you see the same thing locally? Am I seeing something different because I'm using a Windows box?)