Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.12] gh-105268: Remove _PyGC_FINALIZED() macro (#105350)#107348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedJul 27, 2023•
edited by github-actionsbot
Loading

Remove the old private, undocumented and untested _PyGC_FINALIZED() macro which was kept for backward compatibility with Python 3.8 and older.

(cherry picked from commit8ddf0dd)

📚 Documentation preview 📚:https://cpython-previews--107348.org.readthedocs.build/

albanD reacted with rocket emoji
@vstinner
Copy link
MemberAuthor

This change fix PyTorch:#105268 (comment)

@vstinnervstinnerenabled auto-merge (squash)July 27, 2023 14:42
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I am not sure that removing such private and undocumented macro is worth documenting. It received more fame in death than in life.

Remove the old private, undocumented and untested _PyGC_FINALIZED()macro which was kept for backward compatibility with Python 3.8 andolder.(cherry picked from commit8ddf0dd)
@vstinnervstinnerforce-pushed theremove_pygc_finalized312 branch froma31167b to149ad93CompareAugust 14, 2023 19:33
@vstinner
Copy link
MemberAuthor

@Yhg1s: Is this fix eligible in Python 3.12 final? It helps building PyTorch with Python 3.12 if I get it correctly.

@vstinner
Copy link
MemberAuthor

I rebased my PR fix to fix a CI issue. Sadly, 3 weeks ago, the backport couldn't be merged because of a flaky test which failed on the Ubuntu job (unrelated to this PR).

@Yhg1s
Copy link
Member

Removing a macro helps building with PyTorch? That doesn't sound like a straight-forward case. But no, I see no reason this should go into 3.12 (not even two weeks ago, let alone at this stage).

@vstinner
Copy link
MemberAuthor

Ok, in that case, I prefer to not backport this change to 3.12. I close the issue.

auto-merge was automatically disabledAugust 15, 2023 00:12

Pull request was closed

@vstinnervstinner deleted the remove_pygc_finalized312 branchAugust 15, 2023 00:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vstinner@Yhg1s@serhiy-storchaka@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp