Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-107082: Fix instruction size computation for ENTER_EXECUTOR#107256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 2 commits intopython:mainfromgvanrossum:fix-capi-crash
Jul 25, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossumgvanrossum commentedJul 25, 2023
edited by bedevere-bot
Loading

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@gvanrossum for commit92b493d 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJul 25, 2023
@vstinner
Copy link
Member

I tested manually the change on ppc64.I confirm that this change fix./python -m test -v test_capi on big endian machine.

I built Python with./configure --with-pydebug && make -j32: it builds C code withgcc -Og, GCC 13.1.0 on Debian Sid.

Without the fix, I am able to reproduce the issue.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. The change retrieves the original opcode stored in executors by insert_executor().

Co-authored-by: Victor Stinner <vstinner@python.org>
@gvanrossumgvanrossumenabled auto-merge (squash)July 25, 2023 19:26
@gvanrossumgvanrossum merged commit233b878 intopython:mainJul 25, 2023
@gvanrossumgvanrossum deleted the fix-capi-crash branchJuly 25, 2023 20:06
@vstinner
Copy link
Member

Thanks for the fix.

jtcave pushed a commit to jtcave/cpython that referenced this pull requestJul 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_capi: test_extended_arg() failed on PPC64LE RHEL7 Refleaks 3.x
3 participants
@gvanrossum@bedevere-bot@vstinner

[8]ページ先頭

©2009-2025 Movatter.jp