NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-106320: Remove _PyBytes_Join() C API#107144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 2 commits intopython:mainfromvstinner:pycore_bytes

Jul 23, 2023

Merged

gh-106320: Remove _PyBytes_Join() C API#107144

vstinner merged 2 commits intopython:mainfromvstinner:pycore_bytes

Jul 23, 2023

Conversation

Copy link

Member

vstinner commentedJul 23, 2023•
edited by bedevere-bot
Loading

Move private _PyBytes functions to the internal C API (pycore_bytesobject.h):

_PyBytes_DecodeEscape()
_PyBytes_FormatEx()
_PyBytes_FromHex()
_PyBytes_Join()

No longer export these functions.

Issue:C API: Remove private C API functions (move them to the internal C API) #106320

pythongh-106320: Remove _PyBytes_Join() C API

794b99b

Move private _PyBytes functions to the internal C API(pycore_bytesobject.h):* _PyBytes_DecodeEscape()* _PyBytes_FormatEx()* _PyBytes_FromHex()* _PyBytes_Join()No longer export these functions.

vstinner added skip news topic-C-API labels

Jul 23, 2023

vstinner requested review frompablogsal andlysnikolaou ascode owners

July 23, 2023 18:48

bedevere-bot mentioned this pull request

Jul 23, 2023

C API: Remove private C API functions (move them to the internal C API)#106320

Closed

bedevere-bot added the awaiting core review label

Jul 23, 2023

vstinnerenabled auto-merge (squash)

July 23, 2023 18:48

Copy link

MemberAuthor

vstinner commentedJul 23, 2023

I didn't remove the documented_PyBytes_Resize() function:https://docs.python.org/dev/c-api/bytes.html#c._PyBytes_Resize

Fix test_peg_generator: export _PyBytes_DecodeEscape()

bdf5f4c

vstinner merged commit7d41ead intopython:main

Jul 23, 2023

bedevere-bot removed the awaiting core review label

Jul 23, 2023

vstinner deleted the pycore_bytes branch

July 23, 2023 22:38

mementum pushed a commit to mementum/cpython that referenced this pull request

Jul 23, 2023

pythongh-106320: Remove _PyBytes_Join() C API (python#107144)

5d8fbc3

Move private _PyBytes functions to the internal C API(pycore_bytesobject.h):* _PyBytes_DecodeEscape()* _PyBytes_FormatEx()* _PyBytes_FromHex()* _PyBytes_Join()No longer export these functions.

carljm added a commit to carljm/cpython that referenced this pull request

Jul 24, 2023

Merge branch 'main' into superfix

9a6bdfa

* main: (73 commits)  Thoroughly refactor the cases generator (python#107151)  Docs: Add missing markup to Argument Clinic docs (python#106876)pythongh-107162: Document errcode.h usage in its comment (python#107177)pythongh-106320: Remove private _PyDict C API (python#107145)  Fix PyVectorcall_Function doc versionadded (python#107140)  Docs: Remove duplicate word in Argument Clinic howto heading (python#107169)pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104)pythongh-106320: Remove private _PyObject C API (python#107159)  Docs: fix typo in os.pwrite docstring (python#107087)pythongh-105291: Add link to migration guide for distutils (python#107130)pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062)pythongh-106320: Remove _PyBytes_Join() C API (python#107144)pythongh-106320: Remove private _PyObject C API (python#107147)pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143)pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142)  Remove superflous whitespaces in `layout.html`. (pythonGH-107067)pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135)pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)pythongh-62519: Make pgettext search plurals when translation is not found (python#107118)pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127)  ...