Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
Remove superflous whitespaces inlayout.html.#107067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Another option is to add a dash inside the brackets, something likeread the {%- endtrans %} orread the {%- endtrans -%} (https://stackoverflow.com/a/57075716/724176), but this approach is fine too.
Thanks!
Works as expected, tested using |
Thanks for the review and for testing it! |
* main: (73 commits) Thoroughly refactor the cases generator (python#107151) Docs: Add missing markup to Argument Clinic docs (python#106876)pythongh-107162: Document errcode.h usage in its comment (python#107177)pythongh-106320: Remove private _PyDict C API (python#107145) Fix PyVectorcall_Function doc versionadded (python#107140) Docs: Remove duplicate word in Argument Clinic howto heading (python#107169)pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104)pythongh-106320: Remove private _PyObject C API (python#107159) Docs: fix typo in os.pwrite docstring (python#107087)pythongh-105291: Add link to migration guide for distutils (python#107130)pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062)pythongh-106320: Remove _PyBytes_Join() C API (python#107144)pythongh-106320: Remove private _PyObject C API (python#107147)pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143)pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142) Remove superflous whitespaces in `layout.html`. (pythonGH-107067)pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135)pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126)pythongh-62519: Make pgettext search plurals when translation is not found (python#107118)pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127) ...
Thanks for fixing this issue! |
Thanks@ezio-melotti for the PR, and@JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks@ezio-melotti for the PR, and@JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
bedevere-bot commentedJul 25, 2023
GH-107251 is a backport of this pull request to the3.12 branch. |
Uh oh!
There was an error while loading.Please reload this page.
This came up inpython/python-docs-zh-tw#496: after adding
sphinx-lintto the CI workflow it reported 2 errors caused by trailing whitespace:These are caused bytwo strings in
sphinx.po(at line 299 and 313), that are taken fromlayout.html.This PR remove those spaces from
layout.htmlthatshould generate a.powithout trailing whitespace and fix the issue, even though I wasn't able to test it.The spaces after the
<a>s don't create issues but shouldn't be there, whereas the ones before are the problematic ones and I think they can be removed since in both cases there is a newline, which -- once rendered -- should translate to a space before the link in the output.