Movatterモバイル変換

Discourage and deprecatetyping.AnyStr#105578

Open

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

AlexWaygood reviewed

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! Could you also add a note somewhere along the lines of:

Note that, despite its name,AnyStr has nothing to do with theAny type, nor does it mean "any string"

Doc/library/typing.rst OutdatedShow resolvedHide resolved

AlexWaygood added the topic-typing label

JelleZijlstra reviewed

Jul 23, 2023

Doc/library/typing.rst OutdatedShow resolvedHide resolved

Clarify extra examples

202b372

michael-the1 requested review fromAlexWaygood andJelleZijlstra

July 23, 2023 09:42

AlexWaygood added needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Jul 23, 2023

AlexWaygood reviewed

Jul 23, 2023

Doc/library/typing.rst OutdatedShow resolvedHide resolved

Improve comments surrounding new AnyStr examples

1fa3471

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

michael-the1 requested a review fromAlexWaygood

July 25, 2023 20:53

stray "OK" comment

78e7254

AlexWaygood reviewed

Jul 26, 2023

Doc/library/typing.rst OutdatedShow resolvedHide resolved

Remove sentence inAnyStr docs

2cb6a5f

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

michael-the1 requested a review fromAlexWaygood

July 30, 2023 16:03

AlexWaygood approved these changes

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you, looks great!

bedevere-bot added awaiting merge and removed awaiting review labels

AlexWaygood changed the title~~gh-105578: Add more usage examples totyping.AnyStr~~gh-105578: Add more usage examples totyping.AnyStr docs

AlexWaygood merged commitf877b32 intopython:main

Copy link

Contributor

miss-islington commentedJul 31, 2023

Thanks@michael-the1 for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-105578: Add more usage examples totyping.AnyStrdocs (pyt…

ec30258

…honGH-107045)``typing.AnyStr`` has different semantics to ``str | bytes``, which often leads to user confusion(cherry picked from commitf877b32)Co-authored-by: Michael The <michael-the1@users.noreply.github.com>

Copy link

bedevere-bot commentedJul 31, 2023

GH-107503 is a backport of this pull request to the3.12 branch.

bedevere-bot removed the needs backport to 3.12only security fixes label

Copy link

bedevere-bot commentedJul 31, 2023

GH-107504 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-105578: Add more usage examples totyping.AnyStrdocs (pyt…

79af765

…honGH-107045)``typing.AnyStr`` has different semantics to ``str | bytes``, which often leads to user confusion(cherry picked from commitf877b32)Co-authored-by: Michael The <michael-the1@users.noreply.github.com>

AlexWaygood pushed a commit that referenced this pull request

[3.12]gh-105578: Add more usage examples totyping.AnyStrdocs (GH…

9f58d9e

…-107045) (#107503)gh-105578: Add more usage examples to `typing.AnyStr` docs (GH-107045)``typing.AnyStr`` has different semantics to ``str | bytes``, which often leads to user confusion(cherry picked from commitf877b32)Co-authored-by: Michael The <michael-the1@users.noreply.github.com>

AlexWaygood pushed a commit that referenced this pull request