Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106320: Move private _PyGen API to the internal C API#107032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:internal_gen_types
Jul 22, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedJul 22, 2023•
edited by bedevere-bot
Loading

Move private _PyGen API to internal C API:

  • _PyAsyncGenAThrow_Type
  • _PyAsyncGenWrappedValue_Type
  • _PyCoroWrapper_Type
  • _PyGen_FetchStopIterationValue()
  • _PyGen_Finalize()
  • _PyGen_SetStopIterationValue()

No longer these symbols, except of the ones by the _asyncio shared extensions.

Move private _PyGen API to internal C API:* _PyAsyncGenAThrow_Type* _PyAsyncGenWrappedValue_Type* _PyCoroWrapper_Type* _PyGen_FetchStopIterationValue()* _PyGen_Finalize()* _PyGen_SetStopIterationValue()No longer these symbols, except of the ones by the _asyncio sharedextensions.
@rdb
Copy link

rdb commentedAug 4, 2023

If_PyGen_FetchStopIterationValue is no longer public, what is the supported replacement we should use in our project?

@vstinner
Copy link
MemberAuthor

@rdb:

If _PyGen_FetchStopIterationValue is no longer public, what is the supported replacement we should use in our project?

Would you mind to open a new issue to request a public replacement function? Please explain how you use this function, and how existing API is not enough.

@rdb
Copy link

rdb commentedAug 26, 2023•
edited
Loading

@vstinner We've switched to usingPyErr_GetRaisedException() and extracting the value from there (seethis commit), so as long as the structure ofPyStopIterationObject remains part of the public ABI, I think we're good.

@vstinner
Copy link
MemberAuthor

When can add a public function. Just open an issue to ask for it, so we can discuss the issue and decide if it's worth it

@rdb
Copy link

rdb commentedAug 26, 2023

It's not necessary, unless you're telling me thatPyStopIterationObject is going to become opaque in the future.

lachbr pushed a commit to toontownretro/panda that referenced this pull requestFeb 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@rdb@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp