Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-107015: Remove async_hacks from the tokenizer#107018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 3 commits intopython:mainfrompablogsal:gh-107015
Jul 26, 2023

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commentedJul 22, 2023•
edited by github-actionsbot
Loading

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Member

@lysnikolaoulysnikolaou left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good after@Gobot1234's comment has been addressed! Great improvement! 🚀

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't see all the test failures. Most of them are about grammar errors or tests about usingasync/await as soft keywords.@pablogsal Would you like me to take a deeper look into them?

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@pablogsal
Copy link
MemberAuthor

@lysnikolaou I have updated the tests in a separate commit. Please, review again

@pablogsal
Copy link
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@lysnikolaou: please review the changes made to this pull request.

@lysnikolaou
Copy link
Member

lysnikolaou commentedJul 25, 2023•
edited
Loading

Changes to the tests look good. Let's wait for all the tests to pass and merge! Thanks!

@pablogsalpablogsal merged commitda8f87b intopython:mainJul 26, 2023
@pablogsalpablogsal deleted the gh-107015 branchJuly 26, 2023 15:34
jtcave pushed a commit to jtcave/cpython that referenced this pull requestJul 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@lysnikolaoulysnikolaoulysnikolaou approved these changes

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

+1 more reviewer

@Gobot1234Gobot1234Gobot1234 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@bedevere-bot@lysnikolaou@Gobot1234@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp