Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106970: Fix Argument Clinic 'destination <name> clear' command#106972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJul 21, 2023•
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
ContributorAuthor

Thanks for the review, Serhiy!

@erlend-aaslanderlend-aasland merged commit3372bcb intopython:mainJul 22, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106983 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 22, 2023
@miss-islington
Copy link
Contributor

Sorry,@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 3372bcba9893030e4063a9264ec0b4d1b6166883 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 22, 2023
…nd (pythonGH-106972)Add test for the 'destination <name> clear' command,and the 'destination' directive in general.Fix two bugs in 'destination <name> clear' command:1. The text attribute of the allocator is called 'text', not '_text'2. Return after processing the 'clear' command,   instead of proceeding directly to the fail().(cherry picked from commit3372bcb)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Arch Linux TraceRefs 3.x has failed when building commit3372bcb.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/484/builds/3715) and take a look at the build logs.
  4. Check if the failure is related to this commit (3372bcb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/484/builds/3715

Failed tests:

  • test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 33, done.remote:Counting objects:   3% (1/32)remote:Counting objects:   6% (2/32)remote:Counting objects:   9% (3/32)remote:Counting objects:  12% (4/32)remote:Counting objects:  15% (5/32)remote:Counting objects:  18% (6/32)remote:Counting objects:  21% (7/32)remote:Counting objects:  25% (8/32)remote:Counting objects:  28% (9/32)remote:Counting objects:  31% (10/32)remote:Counting objects:  34% (11/32)remote:Counting objects:  37% (12/32)remote:Counting objects:  40% (13/32)remote:Counting objects:  43% (14/32)remote:Counting objects:  46% (15/32)remote:Counting objects:  50% (16/32)remote:Counting objects:  53% (17/32)remote:Counting objects:  56% (18/32)remote:Counting objects:  59% (19/32)remote:Counting objects:  62% (20/32)remote:Counting objects:  65% (21/32)remote:Counting objects:  68% (22/32)remote:Counting objects:  71% (23/32)remote:Counting objects:  75% (24/32)remote:Counting objects:  78% (25/32)remote:Counting objects:  81% (26/32)remote:Counting objects:  84% (27/32)remote:Counting objects:  87% (28/32)remote:Counting objects:  90% (29/32)remote:Counting objects:  93% (30/32)remote:Counting objects:  96% (31/32)remote:Counting objects: 100% (32/32)remote:Counting objects: 100% (32/32), done.remote:Compressing objects:   3% (1/26)remote:Compressing objects:   7% (2/26)remote:Compressing objects:  11% (3/26)remote:Compressing objects:  15% (4/26)remote:Compressing objects:  19% (5/26)remote:Compressing objects:  23% (6/26)remote:Compressing objects:  26% (7/26)remote:Compressing objects:  30% (8/26)remote:Compressing objects:  34% (9/26)remote:Compressing objects:  38% (10/26)remote:Compressing objects:  42% (11/26)remote:Compressing objects:  46% (12/26)remote:Compressing objects:  50% (13/26)remote:Compressing objects:  53% (14/26)remote:Compressing objects:  57% (15/26)remote:Compressing objects:  61% (16/26)remote:Compressing objects:  65% (17/26)remote:Compressing objects:  69% (18/26)remote:Compressing objects:  73% (19/26)remote:Compressing objects:  76% (20/26)remote:Compressing objects:  80% (21/26)remote:Compressing objects:  84% (22/26)remote:Compressing objects:  88% (23/26)remote:Compressing objects:  92% (24/26)remote:Compressing objects:  96% (25/26)remote:Compressing objects: 100% (26/26)remote:Compressing objects: 100% (26/26), done.remote:Total 33 (delta 8), reused 15 (delta 6), pack-reused 1From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '3372bcba9893030e4063a9264ec0b4d1b6166883'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 3372bcba98 gh-106970: Fix Argument Clinic 'destination <name> clear' command (#106972)Switched to and reset branch 'main'Objects/object.c:2234: _Py_ForgetReference: Assertion failed: invalid object chainEnable tracemalloc to get the memory block allocation tracebackobject address  : 0x7f5ac6b6d3f0object refcount : 0object type     : 0x55c555ee28c0object type name: bytesobject repr     : <refcnt 0 at 0x7f5ac6b6d3f0>Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailedPython runtime state: initializedCurrent thread 0x00007f5ad8fb6740 (most recent call first):  <no Python frame>Extension modules: _xxsubinterpreters (total: 1)Debug memory block at address p=0x7f5ad8edde90: API '�'18302063728033390045bytes originally requested    The7 padbytes at p-7 arenotall FORBIDDENBYTE (0xfd):        at p-7:0xdd***OUCH        at p-6:0xdd***OUCH        at p-5:0xdd***OUCH        at p-4:0xdd***OUCH        at p-3:0xdd***OUCH        at p-2:0xdd***OUCH        at p-1:0xdd***OUCH    Because memoryis corrupted at the start, the count ofbytes requested       may be bogus,and checking the trailing padbytes may segfault.    The8 padbytes at tail=0xfdfe7d58d6ebbc6d are Fatal Python error: Segmentation faultCurrent thread 0x00007f5ad8fb6740 (most recent call first):  <no Python frame>Extension modules: _testcapi, _xxsubinterpreters (total: 2)make:*** [Makefile:2025: buildbottest] Segmentation fault (core dumped)Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/test-results.xml' for upload

erlend-aasland added a commit that referenced this pull requestJul 22, 2023
…and (GH-106972) (#106983)Add test for the 'destination <name> clear' command,and the 'destination' directive in general.Fix two bugs in 'destination <name> clear' command:1. The text attribute of the allocator is called 'text', not '_text'2. Return after processing the 'clear' command,   instead of proceeding directly to the fail().(cherry picked from commit3372bcb)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland
Copy link
ContributorAuthor

I'll fix the 3.11 backport later

@erlend-aaslanderlend-aasland deleted the clinic/fix-buffer-series-and-dest-clear branchJuly 22, 2023 09:28
@bedevere-bot
Copy link

GH-107059 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 22, 2023
erlend-aasland added a commit that referenced this pull requestJul 22, 2023
…and (#106972) (#107059)Add test for the 'destination <name> clear' command,and the 'destination' directive in general.Fix two bugs in 'destination <name> clear' command:1. The text attribute of the allocator is called 'text', not '_text'2. Return after processing the 'clear' command,   instead of proceeding directly to the fail().(cherry picked from commit3372bcb)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

@erlend-aaslanderlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@erlend-aasland@miss-islington@bedevere-bot@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp