Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106962: Detect mpicc in configure.ac#106961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 4 commits intopython:mainfromLukasvdWiel:patch-3
Jul 22, 2023

Conversation

@LukasvdWiel
Copy link
Contributor

@LukasvdWielLukasvdWiel commentedJul 21, 2023•
edited
Loading

title:
Fixing Python configure script to handle MPI wrapper around GCC compiler.

summary of the changes made:
Added mpicc to the list of possible compilers that the configure script checks for.

Issue:gh-106962

Full description:

When compiling Python with the MPI wrapper around the GNU C-compilers: mpicc, the configure script that determines the compiler options sees mpicc as the intel compiler because of the 'icc' in the name, and applies the fp-model strict option to the arguments, which is invalid syntax for GCC, causing multiple compile time errors with recent GCC versions:

gcc: error: unrecognized command-line option ‘-fp-model’; did you mean ‘-fipa-modref’?

By first filtering out the mpicc compiler case, this error is prevented.

hen compiling Python with the MPI wrapper around the GNU C-compilers: mpicc, the configure scriptthat determines the compiler options sees mpicc as the intel compiler because of the 'icc' in thename, and applies the fp-model strict option to the arguments, which is invalid syntax for GCC,causing multiple compile time errors with recent GCC versions:gcc: error: unrecognized command-line option ‘-fp-model’; did you mean ‘-fipa-modref’?By first filtering out the mpicc compiler case, this error is prevented.
@ghost
Copy link

ghost commentedJul 21, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@LukasvdWiel
Copy link
ContributorAuthor

LukasvdWiel commentedJul 21, 2023•
edited
Loading

This does not only apply to configure.ac, but exactly the same thing to the main configure script.

Have created issue number: 106962

@sunmy2019sunmy2019 changed the titleUpdate configure.acgh-106962: Update configure.acJul 22, 2023
@sunmy2019
Copy link
Member

You also need to regenerateconfigure with autoconf

erlend-aasland reacted with thumbs up emoji

@erlend-aaslanderlend-aasland changed the titlegh-106962: Update configure.acgh-106962: Detect mpicc in configure.acJul 22, 2023
@erlend-aaslanderlend-aasland added the needs backport to 3.12only security fixes labelJul 22, 2023
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.


case "$CC" in
*mpicc*)
CFLAGS_NODIST="$CFLAGS_NODIST"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Strictly, this line is not needed; we could for example do:

Suggested change
CFLAGS_NODIST="$CFLAGS_NODIST"

I'm also fine with the current line.

@erlend-aaslanderlend-aaslandenabled auto-merge (squash)July 22, 2023 22:37
@erlend-aaslanderlend-aasland merged commit9a6b278 intopython:mainJul 22, 2023
@miss-islington
Copy link
Contributor

Thanks@LukasvdWiel for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-107081 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 22, 2023
Don't let autoconf mistake MPI compilers for Intel compilers;filter out the MPI case to prevent Intel specific options from being applied.(cherry picked from commit9a6b278)Co-authored-by: Lukas van de Wiel <30800501+LukasvdWiel@users.noreply.github.com>
@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 22, 2023
erlend-aasland pushed a commit that referenced this pull requestJul 23, 2023
Don't let autoconf mistake MPI compilers for Intel compilers;filter out the MPI case to prevent Intel specific options from being applied.(cherry picked from commit9a6b278)Co-authored-by: Lukas van de Wiel <30800501+LukasvdWiel@users.noreply.github.com>
jtcave pushed a commit to jtcave/cpython that referenced this pull requestJul 23, 2023
Don't let autoconf mistake MPI compilers for Intel compilers;filter out the MPI case to prevent Intel specific options from being applied.
mementum pushed a commit to mementum/cpython that referenced this pull requestJul 23, 2023
Don't let autoconf mistake MPI compilers for Intel compilers;filter out the MPI case to prevent Intel specific options from being applied.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LukasvdWiel@bedevere-bot@sunmy2019@miss-islington@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp